Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestTestRaceInstall is too slow to run when -short specified #20158

Closed
alexbrainman opened this issue Apr 28, 2017 · 6 comments
Closed

cmd/go: TestTestRaceInstall is too slow to run when -short specified #20158

alexbrainman opened this issue Apr 28, 2017 · 6 comments
Labels
FrozenDueToAge

Comments

@alexbrainman
Copy link
Member

I was investigating why running "go test -short cmd/go" is slow on my computer, And I noticed TestTestRaceInstall was added recently. TestTestRaceInstall takes a while to run:

c:\>go test -v -run=TestTestRaceInstall cmd/go
=== RUN   TestTestRaceInstall
--- PASS: TestTestRaceInstall (27.30s)
        go_test.go:269: running testgo [install -race -pkgdir=C:\Users\Alex\AppData\Local\Temp\gotest749145327\pkg std]
        go_test.go:269: running testgo [test -race -pkgdir=C:\Users\Alex\AppData\Local\Temp\gotest749145327\pkg -i -v empty/pkg]
PASS
ok      cmd/go  31.923s

But TestTestRaceInstall is run when -short flag is provided. I wonder if we should skip this test for -short.

Alex

PS: My computer is slow, but it is not slowest in the world.
@mvdan mvdan changed the title cmd/go: TestTestRaceInstall is to slow to run when -short specified cmd/go: TestTestRaceInstall is too slow to run when -short specified Apr 28, 2017
@mvdan
Copy link
Member

mvdan commented Apr 28, 2017

Even on my new-ish laptop with an SSD, it takes ~15s. Agreed on making it be skipped on -short.

@alexbrainman
Copy link
Member Author

Agreed on making it be skipped on -short.

Thank you @mvdan for support :-), but I doubt you and me could make that decision.
Leaving it for others.

Alex

@mvdan
Copy link
Member

mvdan commented Apr 28, 2017 •
edited

Oh, sure - was meant as "sounds like a good idea" more than "let's do that".

@ianlancetaylor
Copy link
Contributor

SGTM

@gopherbot
Copy link

CL https://golang.org/cl/42134 mentions this issue.

@alexbrainman
Copy link
Member Author

@ianlancetaylor my computer says thanks to you.
(So it doesn't have to work as hard.)

Alex

@golang golang locked and limited conversation to collaborators Apr 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianlancetaylor @mvdan @gopherbot @alexbrainman