Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestClosedPipeRaceWrite fails on ppc64x #20134

Closed
mundaym opened this issue Apr 26, 2017 · 8 comments
Closed

os: TestClosedPipeRaceWrite fails on ppc64x #20134

mundaym opened this issue Apr 26, 2017 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@mundaym
Copy link
Member

mundaym commented Apr 26, 2017

This new test, added in e3d7ec0, seems to have broken the ppc64x builders.

--- FAIL: TestClosedPipeRaceWrite (0.00s)
	pipe_test.go:157: I/O on closed pipe unexpectedly succeeded
FAIL
FAIL	os	0.341s
@mundaym mundaym added this to the Go1.9 milestone Apr 26, 2017
@bradfitz
Copy link
Contributor

/cc @ianlancetaylor

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 26, 2017
@laboger
Copy link
Contributor

laboger commented Apr 26, 2017

Kind of odd that this passed the buildbots but fails everywhere else?

@mundaym
Copy link
Member Author

mundaym commented Apr 26, 2017

@laboger I could be wrong but I think the trybots only check that the distribution compiles when targeting ppc64(le?), I don't think they actually run the tests on ppc64x. Does it fail for you locally?

@bradfitz
Copy link
Contributor

Correct. Trybots (pre-submit tests) only compile ppc64x but don't run the tests. Post-submit builds run the tests on ppc64x hardware. We need lots of hardware to support trybots.

@ianlancetaylor
Copy link
Contributor

What does getconf PIPE_BUF /tmp print on your system?

@bradfitz
Copy link
Contributor 

$ gomote create linux-ppc64-buildlet
user-bradfitz-linux-ppc64-buildlet-0
$ gomote run -system user-bradfitz-linux-ppc64-buildlet-0 getconf PIPE_BUF /tmp
4096

$ gomote create linux-ppc64le-buildlet
user-bradfitz-linux-ppc64le-buildlet-0
$ gomote run -system user-bradfitz-linux-ppc64le-buildlet-0 getconf PIPE_BUF /tmp                                                                                                              
4096

@ianlancetaylor
Copy link
Contributor

OK, that is just weird. This should not be processor dependent.

@gopherbot
Copy link

CL https://golang.org/cl/41823 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
5 participants
@bradfitz @ianlancetaylor @gopherbot @laboger @mundaym