-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: make misc-compile-all trybot type check tests too #20119
Comments
CL https://golang.org/cl/41752 mentions this issue. |
Cleanup CL https://golang.org/cl/41691 broke the plan9 build by removing a use of a package but not removing the package import. Trybots don't check that. I filed #20119 for that. Change-Id: Ia030e6924665dfb871ca964455b899d51b0200c2 Reviewed-on: https://go-review.googlesource.com/41752 Reviewed-by: David du Colombier <0intro@gmail.com>
Notes: The misc builders are defined here: They use buildall.bash to run: (ignore the typo in docs that says All that basically does (from a fast linux-amd64 kubernetes container) is:
We'd also need a way to also make buildall.bash run "go test -c $PKG" for each $PKG. That is #15513. |
Yeah, I tried just modifying buildall.bash to run |
Note that Alternatively, |
Packages with tests: $ for PKG in $(go list -f "{{.ImportPath}} {{.TestGoFiles}}" std cmd | \
grep -v ' \[\]$' | perl -npe 's/ .+//'); do \
echo $PKG; \
done |
Until #15513 is resolved, would it be okay to use the |
@paranoiacblack, no, because buildall.bash always runs on linux-amd64 and |
CL https://golang.org/cl/42531 mentions this issue. |
Change https://golang.org/cl/176439 mentions this issue: |
The "misc-compile-*" Trybot builders try to at least compile & type check every GOOS/GOARCH pair, even when we don't have sufficient hardware to run the tests.
But they apparently don't compile or type check tests.
https://go-review.googlesource.com/c/41691/ broke Plan 9 without any warnings.
Fix that.
/cc @mvdan @kevinburke @adams-sarah @cybrcodr
The text was updated successfully, but these errors were encountered: