We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running make.bash on the ARM5 spacemonkey hardware takes 27 minutes.
We could cross-compile it from Kubernetes like we do for the linux-arm Scaleway trybot builders.
It looks like it's pretty much already set up in coordinator.go,
type crossCompileConfig struct { Buildlet string CCForTarget string GOARM string } var crossCompileConfigs = map[string]*crossCompileConfig{ "linux-arm": { Buildlet: "host-linux-armhf-cross", CCForTarget: "arm-linux-gnueabihf-gcc", GOARM: "7", }, "linux-arm-arm5spacemonkey": { Buildlet: "host-linux-armel-cross", CCForTarget: "arm-linux-gnueabi-gcc", GOARM: "5", }, } func (st *buildStatus) crossCompileMakeAndSnapshot(config *crossCompileConfig) (err error) {
But this part means it's not being run for non-trybots:
func (st *buildStatus) getCrossCompileConfig() *crossCompileConfig { if kubeErr != nil { return nil } if inStaging || st.isTry() { return crossCompileConfigs[st.name] } return nil }
/cc @zeebo
The text was updated successfully, but these errors were encountered:
Should we be running for non-trybots? What kind of logic do we want for this?
Let's have it configurable per each cross compiler config and add a OnlyForTry boolean to the config.
Sorry, something went wrong.
arm5 is way too slow to ever be a trybot. We're only going to be running post-submit builds for this builder type.
Ok. I'll just remove that condition then and always return a config if it's available and there's no kubernetes error.
Oh, sorry, I misread your comment. We don't want to waste resources cross-compiling for linux-arm for post-submit builds, so:
Yes, that sounds good. Add that bool.
CL https://golang.org/cl/41755 mentions this issue.
golang/build@27cd84a
No branches or pull requests
Running make.bash on the ARM5 spacemonkey hardware takes 27 minutes.
We could cross-compile it from Kubernetes like we do for the linux-arm Scaleway trybot builders.
It looks like it's pretty much already set up in coordinator.go,
But this part means it's not being run for non-trybots:
/cc @zeebo
The text was updated successfully, but these errors were encountered: