New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: Some VirtualX syscalls missing #20086
Comments
@libeclipse would something like alexbrainman/winapi@c959b37 do? Alex |
@alexbrainman That's a cool little library you have there. Of course it would be nice to have the calls in /x/ eventually, but for now that will do perfectly! |
@alexbrainman are you going to make those changes into |
I was not planing to. Alex |
Shouldn't |
No. I think it is impossible to have ALL Windows APIs in x/sys/windows. As you can see (#20086 (comment)), it is very easy do add whatever APIs you desire to your own package. Alex |
CL https://golang.org/cl/47333 mentions this issue. |
CL https://golang.org/cl/47334 mentions this issue. |
CL https://golang.org/cl/47335 mentions this issue. |
Fixes golang/go#20086 Change-Id: Ifdc2561fe6cc125fa45a57bad9750f3f3f055e66 Reviewed-on: https://go-review.googlesource.com/47335 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
What did you expect to see?
On https://godoc.org/golang.org/x/sys/windows I expected to see the
VirtualAlloc
andVirtualFree
syscalls, and also theVirtualProtect
one.What did you see instead?
Only the
VirtualLock
and its unlocking counterpart.These are quite important from a security perspective, are there any plans to have them added?
The text was updated successfully, but these errors were encountered: