x/net/trace: use std context package #20056
Comments
bradfitz
changed the title
|
CL https://golang.org/cl/41290 mentions this issue. |
|
This is a cascading problem. grpc-go is now broken since this package is a dependency of ours and we support Go 1.6. We are blocked on deprecating 1.6 and updating our imports until generated proto files use the standard context package. AppEngine only supports Go1.6, so I believe the proto compiler can't be changed until that is updated. Is it possible to revert these context changes and hold off on them until Go1.6 is less widely used? |
|
@dfawley, where is the grpc-go breakage? Got some URLs? |
|
Our tests only run on PRs and merges, so the main page doesn't show this breakage. Here's an example from an in-progress PR: |
|
+1 on being affected by breakage. This breaks Google Cloud client libraries using gRPC on App Engine standard, which is stuck on Go 1.6. |
|
It's been 14 months since Go 1.6. App Engine can't get another release out? Is that really what this is all about? Go's policy is that we only test and maintain the past two releases. I could add some build tag chicanery into x/net/trace, but our builders aren't testing 1.6 anymore. I don't want to revert the change. We want to make forward progress on cleanups and other people want us to use std context. Let me see what I can do. |
|
yak, getting this error now after this change . golang.org/x/net/trace/trace.go:67: can't find import: "context" |
App Engine is stuck 14 months in the past and doesn't have context. Updates golang/go#20056 Change-Id: I2cb2a3a75af07728805be8c714e4725f01a17074 Reviewed-on: https://go-review.googlesource.com/41413 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Can we have
contexthere https://github.com/golang/net/blob/master/trace/trace.go#L80?This golang/time@c06e80d happened. Would the same change in
tracebreak anything?It's one of our sub-dependency and would like to know when this would happen :)
Thanks in advance!
The text was updated successfully, but these errors were encountered: