encoding/base32: The decoder returned by NewDecoder sometimes drops errors #20044
Labels
FrozenDueToAge
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
bradfitz
added
NeedsInvestigation
|
Multiple potential issues: use of io.ReadAtLeast drops errors if it reads enough, and base32.go stores into d.err from ReadAtLeast but overwrites it without consulting it d.nbuf >= 8. |
|
@bradfitz Any objections if I take a look at this? |
|
@markdryan, all yours. |
|
I've created a patch that addresses this issue: https://go-review.googlesource.com/c/42094/ The patch fixes the error propagation issues and adds some new unit tests. |
|
CL https://golang.org/cl/42094 mentions this issue. |
|
Looks like that patch needs some reviewers... |
|
ascii85, base64 have similar bugs -- should I file new bugs for those? |
|
We shouldn't reuse this bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?1.8.1
What operating system and processor architecture are you using (
go env)?darwin amd64
What did you do?
When passing an
io.Readertobase32.NewDecoder, if that reader emits valid base32 input and an error, I would expect that error to be propagated. Instead, it is dropped.Example: https://play.golang.org/p/Ex-8nNLiZk
In this case, it's because
io.ReadAtLeastdrops errors if the minimum is reached (another surprising thing), but it looks like other encoders (ascii85, base64) exhibit similar behavior, perhaps on purpose. If it is on purpose, it should be documented somewhere.The text was updated successfully, but these errors were encountered: