Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: broken builder (FAILED: not a Git repo) #20036

Closed
tzneal opened this issue Apr 19, 2017 · 5 comments
Closed

x/build: broken builder (FAILED: not a Git repo) #20036

tzneal opened this issue Apr 19, 2017 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@tzneal
Copy link
Member

tzneal commented Apr 19, 2017

A change I made that was merged into master ( dc44441) , resulted in a failed build on darwin-amd64-10_8 that I had never seen before:

https://build.golang.org/log/2004e9acdc91c824ee11d884315616232d1f46c8

darwin-amd64-10_8 at dc444418d919b72f7744a521cc898252f3f355df

:: Running /var/folders/_m/7l4dhkzx3rg5v97tqbz5wkmr0000gn/T/workdir/go/src/make.bash with args ["/var/folders/_m/7l4dhkzx3rg5v97tqbz5wkmr0000gn/T/workdir/go/src/make.bash"] and env ["TERM_PROGRAM=Apple_Terminal" "TERM=xterm-256color" "SHELL=/bin/bash" "TMPDIR=/var/folders/_m/7l4dhkzx3rg5v97tqbz5wkmr0000gn/T/" "Apple_PubSub_Socket_Render=/tmp/launch-Ou6u40/Render" "TERM_PROGRAM_VERSION=309" "TERM_SESSION_ID=4A55C283-E1E7-4589-A535-377B9747351C" "USER=gopher" "COMMAND_MODE=unix2003" "SSH_AUTH_SOCK=/tmp/launch-Am5hb1/Listeners" "__CF_USER_TEXT_ENCODING=0x1F5:0:0" "Apple_Ubiquity_Message=/tmp/launch-YmFHRu/Apple_Ubiquity_Message" "PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin" "GO_BUILDER_ENV=macstadium_vm" "PWD=/Users/gopher" "LANG=en_US.UTF-8" "SHLVL=3" "HOME=/Users/gopher" "LOGNAME=gopher" "SECURITYSESSIONID=186a4" "_=./buildlet" "GOROOT_BOOTSTRAP=/Users/gopher/go1.4" "WORKDIR=/var/folders/_m/7l4dhkzx3rg5v97tqbz5wkmr0000gn/T/workdir" "GO_BUILDER_NAME=darwin-amd64-10_8" "GOBIN="] in dir /var/folders/_m/7l4dhkzx3rg5v97tqbz5wkmr0000gn/T/workdir/go/src

##### Building Go bootstrap tool.
cmd/dist

go tool dist: FAILED: not a Git repo; must put a VERSION file in $GOROOT

build failed: make script failed: exit status 2

/cc @bradfitz
@tzneal tzneal added the Builders x/build issues (builders, bots, dashboards) label Apr 19, 2017
@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2017
@bradfitz
Copy link
Contributor

Uh, bizarre. Never seen that. The build system does write a dummy VERSION file in $GOROOT before each build starts. Maybe it failed and we didn't catch an error? Maybe the filesystem crapped itself? No clue.

@bradfitz bradfitz added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 19, 2017
@zhexuany
Copy link

Seems to me this was caused by the failure of isGitRepo in build.go https://github.com/golang/go/blob/master/src/cmd/dist/build.go#L309

I did compelling on my machine: everything is passed.

@bradfitz
Copy link
Contributor

@zhexuany, yes, that's where the error came from, but it shouldn't have gotten that far. It should've stopped at the VERSION check a few lines up from there.

@zhexuany
Copy link

zhexuany commented Apr 19, 2017 •
edited

@bradfitz I second your opinion. I reset commit history hardly on dc44441. And then execute ./make.bash. Everything works just fine. findgoversion() should return before even execute isGitRepo(). I am trying setting goroot to a git repo and see what is the result.

@bradfitz
Copy link
Contributor

bradfitz commented Dec 6, 2017

I'm going to close this since we've never seen it again. Also, I'm changing the Macs to nuke themselves every build, so if this was filesystem corruption over time, that won't be an issue anymore.

@bradfitz bradfitz closed this as completed Dec 6, 2017
@golang golang locked and limited conversation to collaborators Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @tzneal @gopherbot @zhexuany