Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect: StructOf should support embedding types with non-exported methods #20015

Open
mdempsky opened this issue Apr 17, 2017 · 3 comments
Open

reflect: StructOf should support embedding types with non-exported methods #20015

mdempsky opened this issue Apr 17, 2017 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@mdempsky
Copy link
Member

There's this code in reflect/type.go:

                                    if ift.nameOff(m.name).pkgPath() != "" {
                                            // TODO(sbinet)
                                            panic("reflect: embedded interface with unexported method(s) not implemented")
                                    }

See also #5748.
@mdempsky mdempsky mentioned this issue Apr 17, 2017
Closed
@bradfitz bradfitz added this to the Unplanned milestone Apr 17, 2017
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Apr 17, 2017
@rberenguel
Copy link

How hard do you reckon this to be @bradfitz @mdempsky ? I'm vaguely familiar with the internals of reflect already (had to do something weird recently and explored it a lot for inspiration), so would love a try if possible to improve my understanding of it.

@ianlancetaylor
Copy link
Contributor

@rberenguel It would be great if you want to work on this, but unfortunately I think it will be pretty hard.

@rberenguel
Copy link

Thanks @ianlancetaylor a bad choice then for the first contribution. I'll keep looking!

@cosmos72 cosmos72 mentioned this issue Jun 13, 2020
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @mdempsky @rberenguel @ianlancetaylor @gopherbot