Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: add knobs for which headers Client forwards on redirect? #19973

Closed
zachgersh opened this issue Apr 14, 2017 · 5 comments
Closed

net/http: add knobs for which headers Client forwards on redirect? #19973

zachgersh opened this issue Apr 14, 2017 · 5 comments
Labels
FrozenDueToAge help wanted
Milestone
Unplanned

Comments

@zachgersh
Copy link

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.8.1

What operating system and processor architecture are you using (go env)?

amd64/darwin

What did you do?

Making a request to upload a file that is setting the content-type of application/x-compressed which results in a successful 302 redirect to a task monitoring endpoint.

What did you expect to see?

The request succeeds and the task monitoring endpoint returns a 200.

What did you see instead?

The endpoint fails due to the fact that it has received the additional header.

I know I can implement a CheckRedirect function that would allow me to strip out the headers but it seems like the go 1.7.X behavior was more desirable (providing the function to forward the headers).

It actually might be nice to make this a flag on the client (so headers can be optionally be forwarded or not). Having to implement CheckRedirect just to not send along headers feels a tad bit heavy handed but I am open to it.

I also know that the API server, which I have no control over, could be modified to ignore additional headers but the code I have talking to this server worked in 1.7.X and now doesn't work in 1.8.1 (slightly surprising).
@bradfitz bradfitz changed the title net/http/client - forwarding of all headers on redirect sometimes bad? net/http: add knobs for which headers Client forwards on redirect? Apr 14, 2017
@bradfitz
Copy link
Contributor

For 8 releases people complained about the lack of header forwarding and we kept putting it off and thinking about it. And then we did it, and... this. :)

I'll entertain proposals but I don't have the resources to think about this more and design the API myself.

@bradfitz bradfitz added this to the Unplanned milestone Apr 14, 2017
@zachgersh
Copy link
Author

@bradfitz I almost dreaded putting this in because it felt like a "damned if you do, damned if you don't" sort of behavior. I'd be glad to take this on and rough it out, of course as long as you are willing to provide feedback 😄

Easiest solution:

Client now takes a bool for RedirectHeaders.

I'd love to see if anyone else has run into this and/or cares. Also, thanks for all you do and even being open to the idea.

@bradfitz
Copy link
Contributor

We're not going to make the behavior off in 1.0-1.7, on in 1.8, and off again in 1.9. It's going to be on by default now. So any bool would need to turn it off, so would need a different name.

But a bool might not be flexible enough. A func(string) bool might be better. A per-key policy func or something. And then there could be predefined funcs/vars for AllowAll or AllNone. And a nil func (the default) would be a Go-defined policy, like we have in 1.8.

@dpb587-pivotal dpb587-pivotal mentioned this issue Apr 14, 2017
Closed
@kkallday kkallday mentioned this issue Jun 16, 2017
Closed
zachgersh pushed a commit to terrorform/go that referenced this issue Feb 21, 2018
net/http: optionally add headers on redirect
f369c10 
Fixes golang#19973
@zachgersh zachgersh mentioned this issue Feb 21, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/95895 mentions this issue: net/http: optionally add headers on redirect

@zachgersh
Copy link
Author

I am also closing this issue. Seems like the default behavior is fine as @bradfitz originally stated.

@golang golang locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Unplanned
Development

Successfully merging a pull request may close this issue.

net/http: optionally add headers on redirect terrorform/go
3 participants
@bradfitz @zachgersh @gopherbot