Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: TestRuntimeTypeDIEs failing on Plan 9 #19944

Closed
0intro opened this issue Apr 12, 2017 · 1 comment
Closed

cmd/link: TestRuntimeTypeDIEs failing on Plan 9 #19944

0intro opened this issue Apr 12, 2017 · 1 comment
Labels
FrozenDueToAge

Comments

@0intro
Copy link
Member

0intro commented Apr 12, 2017

TestRuntimeTypeDIEs has been added in CL 38350 and is failing on Plan 9. This is happening because Plan 9 executable don't have a DWARF symbol table.

--- FAIL: TestRuntimeTypeDIEs (0.51s)
	dwarf_test.go:31: error reading DWARF: no DWARF data in Plan 9 file
FAIL
FAIL	cmd/link/internal/ld	0.538s

See https://build.golang.org/log/891a7b19195b38cf2fd5263dcd7f0fc44cb75812
@gopherbot
Copy link

CL https://golang.org/cl/40452 mentions this issue.

lparth pushed a commit to lparth/go that referenced this issue Apr 13, 2017
@0intro @lparth
cmd/link: skip TestRuntimeTypeDIEs on Plan 9
1ea6d91 
TestRuntimeTypeDIEs has been added in CL 38350. This
test is failing on Plan 9 because executables don't
have a DWARF symbol table.

Fixes golang#19944.

Change-Id: I121875bfd5f9f02ed668f8fb0686a0edffa2a99d
Reviewed-on: https://go-review.googlesource.com/40452
Run-TryBot: David du Colombier <0intro@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0intro @gopherbot