cmd/compile: remove Type.Vargen #19878
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
|
Apologies for making things more difficult. Hopefully this is temporary. To a large extent, types, symbols, and scopes (dclstack etc) should be able to stand alone, which hopefully should allow significant disentanglements in the long run. In the short run, things are a bit ugly. |
No worries. All in the name of progress. :) I'm sure my incessant ongoing refactoring of the last weeks has caused no shortage of rebase pain to others. |
andybons
added
the
NeedsFix
gopherbot
added
the
compiler/runtime
|
It's removed after https://go-review.googlesource.com/c/go/+/527517. cc @mdempsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The only place that Type.Vargen is written is in typechecking, where is it set with
t.Vargen = n.Name.Vargen. A few lines later, we also provide t with a reference to n:t.Nod = asTypesNode(n). So Type.Vargen could be implemented as a lazy lookup of t.Nod.Name.Vargen, defaulting to zero if t.Nod or t.Nod.Name are nil.I'd send a CL, but amusingly, yesterday's refactoring made it more difficult, because Nod fields are now inaccessible from Types. If we switch to using (say) an interface for Type.Nod, then the Node Vargen lookup could become part of that interface. Conveniently, removing Type.Vargen would almost pay for that, size-wise.
cc @mdempsky @griesemer
The text was updated successfully, but these errors were encountered: