Skip to content

cmd/compile: remove Type.Vargen #19878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josharian opened this issue Apr 7, 2017 · 3 comments
Closed

cmd/compile: remove Type.Vargen #19878

josharian opened this issue Apr 7, 2017 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@josharian
Copy link
Contributor

The only place that Type.Vargen is written is in typechecking, where is it set with t.Vargen = n.Name.Vargen. A few lines later, we also provide t with a reference to n: t.Nod = asTypesNode(n). So Type.Vargen could be implemented as a lazy lookup of t.Nod.Name.Vargen, defaulting to zero if t.Nod or t.Nod.Name are nil.

I'd send a CL, but amusingly, yesterday's refactoring made it more difficult, because Nod fields are now inaccessible from Types. If we switch to using (say) an interface for Type.Nod, then the Node Vargen lookup could become part of that interface. Conveniently, removing Type.Vargen would almost pay for that, size-wise.

cc @mdempsky @griesemer
@griesemer
Copy link
Contributor

Apologies for making things more difficult. Hopefully this is temporary. To a large extent, types, symbols, and scopes (dclstack etc) should be able to stand alone, which hopefully should allow significant disentanglements in the long run. In the short run, things are a bit ugly.

@josharian
Copy link
Contributor Author

Apologies for making things more difficult.

No worries. All in the name of progress. :) I'm sure my incessant ongoing refactoring of the last weeks has caused no shortage of rebase pain to others.

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 11, 2018
@andybons andybons added this to the Unplanned milestone Apr 11, 2018
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
@cuonglm
Copy link
Member

cuonglm commented Oct 5, 2023

It's removed after https://go-review.googlesource.com/c/go/+/527517.

cc @mdempsky

@cuonglm cuonglm closed this as completed Oct 5, 2023
@golang golang locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@josharian @andybons @cuonglm @griesemer @gopherbot