-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: wrong names during nested struct decomposition #19868
Comments
CL https://golang.org/cl/40010 mentions this issue. |
For the record, the CL for this got abandoned a little while ago. |
I am trying to revive this, I assume it would be helpful. |
I think so. I found the problem by inspection, not by hitting it myself, so I don't know how critical it is. But it seems like anything working with small nested structs would be affected, so it seems worth fixing to me. |
Change https://golang.org/cl/71731 mentions this issue: |
The tests are very broken because of refactoring, I'm wondering how hard it would be to turn this into an end-to-end test. Seems like if it matters, there must be a way to make it be user-visible. I've also as yet had poor luck with any of my little tests when I optimize them. Everything is always reported as |
The struct variable in
f
gets decomposed correctly. The generated code spills the two parts of c to stack slots named "c.x" and "c.y". We should get similar stack slots named "c.a.x" and "c.b.y" ing
, but we don't. We just get autotmps.@heschik @dr2chase @mdempsky
The text was updated successfully, but these errors were encountered: