Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: go get/build/install Makefile support #19849

Closed
saschagrunert opened this issue Apr 5, 2017 · 1 comment
Closed

proposal: go get/build/install Makefile support #19849

saschagrunert opened this issue Apr 5, 2017 · 1 comment

Comments

@saschagrunert
Copy link

saschagrunert commented Apr 5, 2017

Hey Gophers, I have a proposal for a more flexible build environment:

If I run go get or go build then would it be great if it executes make if a Makefile exists in the current directory. It could also work via a configuration flag:

go build --backend=make

Furthermore it would be good to use such options via a configuration file (like a Go.toml inside the main directory, our Rust brothers already do this), to tell the compiler to apply package specific settings during a simple execution of go build.

This has the benefit that I can create more flexible build environments, like downloading artifacts from certain place during the build. What do you think?

@gopherbot gopherbot added this to the Proposal milestone Apr 5, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Apr 5, 2017

This would not be portable (won't work on Windows), won't work if you don't have the tools in general, and means a "go get" suddenly can run arbitrary code on your machine, which has never been the case before.

We tend to check in auto-generated build artifacts instead (see https://blog.golang.org/generate).

Sorry, I'm going to decline this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants