Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: building mips* hangs #19842

Closed
josharian opened this issue Apr 4, 2017 · 7 comments
Closed

cmd/compile: building mips* hangs #19842

josharian opened this issue Apr 4, 2017 · 7 comments
Labels
FrozenDueToAge

Comments

@josharian
Copy link
Contributor

Reproduce:

$ GOOS=linux GOARCH=mipsle go build runtime

Introduced by https://go-review.googlesource.com/38801 (cmd/compile: automatically handle commuting ops in rewrite rules). Also shows up on build.golang.org as a blank mipsle column. I presume there's an infinite loop somewhere in one of the mips build rules.

This is currently blocking me, so I'll take a look now.

cc @randall77
@gopherbot
Copy link

CL https://golang.org/cl/39533 mentions this issue.

@josharian
Copy link
Contributor Author

Looks like the builder is still wedged, based on build.golang.org. Re-opening until the dashboard is functional again. I still can't remember who runs the mipsle builder, and https://github.com/golang/go/wiki/DashboardBuilders doesn't say.

Whoever runs the mipsle builder, can you kill all the old compilation processes that are spinning, and please update the wiki so I can find you in the future? Thanks.

cc @minux because maybe he knows who runs the builder.

@josharian josharian reopened this Apr 4, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Apr 4, 2017

@josharian, the page you linked to references http://farmer.golang.org/builders at the top, and http://farmer.golang.org/builders says who owns it. (Brendan Kirby, imgtec.com)

@cherrymui
Copy link
Member

The owner of the builder is @MIPSbkirby, as per comments in #19641.

@josharian josharian mentioned this issue Apr 5, 2017
Closed
@josharian
Copy link
Contributor Author

Thanks @bradfitz. I edited the wiki to make that section stand out a bit more and filed #19848 as a follow-up.

Thanks, @cherrymui, for pinging Brendan.

@MIPSbkirby
Copy link

I'm killing the build processes that are building commits before fc327a1 to get this cleaned up. When it starts builds at or after that commit, I'll leave it alone.

@josharian
Copy link
Contributor Author

Thanks, @MIPSbkirby! Looks like the build dashboard is slowly recovering.

lparth pushed a commit to lparth/go that referenced this issue Apr 13, 2017
@josharian @lparth
cmd/compile: remove order canonicalization rules from mips
a70abc5 
CL 38801 introduced automatic commutative rule generation.
Manual order canonicalization rules thus lead to infinite loops.

Fixes golang#19842

Change-Id: I877c476152f4d207fdc67bc6f3018265aa9bc5ac
Reviewed-on: https://go-review.googlesource.com/39533
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
@golang golang locked and limited conversation to collaborators Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bradfitz @josharian @MIPSbkirby @gopherbot @cherrymui