Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: recent mach-o CL broke the nocgo builder #19796

Closed
josharian opened this issue Mar 30, 2017 · 2 comments
Closed

runtime: recent mach-o CL broke the nocgo builder #19796

josharian opened this issue Mar 30, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@josharian
Copy link
Contributor

18e7767

https://build.golang.org/log/5b7a17de0c72ba8b465b80e78c68d814c6d6ebf4

Fix coming shortly.
@gopherbot
Copy link

CL https://golang.org/cl/38992 mentions this issue.

@bradfitz bradfitz mentioned this issue Mar 30, 2017
Closed
@bradfitz bradfitz added this to the Go1.9 milestone Mar 30, 2017
@gopherbot
Copy link

CL https://golang.org/cl/39612 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 5, 2017
@josharian @aclements
[release-branch.go1.8] cmd/link: skip TestDWARF when cgo is disabled
d7989b7 
While we're here, fix a Skip/Skipf error I noticed.

Fixes #19796.

(This fixes failures on the release branch introduced by cherry-pick
CL 39605.)

Change-Id: I59b1f5b5ea727fc314acfee8445b3de0b5af1e46
Reviewed-on: https://go-review.googlesource.com/39612
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
lparth pushed a commit to lparth/go that referenced this issue Apr 13, 2017
@josharian @lparth
cmd/link: skip TestDWARF when cgo is disabled
245cf87 
While we're here, fix a Skip/Skipf error I noticed.

Fixes golang#19796.

Change-Id: I59b1f5b5ea727fc314acfee8445b3de0b5af1e46
Reviewed-on: https://go-review.googlesource.com/38992
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @josharian @gopherbot