Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: go1.8 pprof proto output doesn't include symbol info. #19786

Closed
hyangah opened this issue Mar 30, 2017 · 3 comments
Closed

runtime/pprof: go1.8 pprof proto output doesn't include symbol info. #19786

hyangah opened this issue Mar 30, 2017 · 3 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 30, 2017

go1.8 release branch doesn't include https://go-review.googlesource.com/c/34192/
which confuses pprof that expects symbol info.

https://github.com/golang/go/commits/release-branch.go1.8/src/runtime/pprof

@aclements
Copy link
Member

@hyangah, what do you mean by "confuses pprof that expects symbol info"?

@rsc
Copy link
Contributor

rsc commented Apr 5, 2017

I tested Go 1.8 and it works fine with the Go 1.8 go tool pprof (see google/pprof#120 (comment)).
What it doesn't work fine with is the current github.com/google/pprof.
People can and should be using go tool pprof instead.

Not for point release.

@rsc
Copy link
Contributor

rsc commented Apr 5, 2017

(Not even our bug.)

@rsc rsc closed this as completed Apr 5, 2017
@rsc rsc removed this from the Go1.8.1 milestone Apr 5, 2017
@golang golang locked and limited conversation to collaborators Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants