New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sync/errgroup: should use context.Context from stdlib #19781
Comments
We'll do this when Go 1.9 is released. (We generally try to support the past few Go releases in the golang.org/x/* repos) |
I ran into this today on Go 1.9, any chance to get this fixed? |
Yes, I think we can make this change now. Want to send a patch? |
What are the compatibility requirements, should I use conditional compilation? or can I simply just use "context". Additionally, where is the repository for this? I suppose I need to set up gerrit as a go contributor, but is the |
I think we can just use "context". At least, we can see if anyone complains. You can fetch the package via |
First go commit, I think I did everything correctly. Changeset here: |
Change https://golang.org/cl/84481 mentions this issue: |
https://golang.org/cl/84481 replace context without complexity. So, it can be merged when App Engine will move to Go1.8 ("the policy they decided upon is to wait until January 2nd" - by Joe Tsai) |
Update on the issue from the CL thread. If anyone wants to follow -
|
@jba - Should this be pushed to 1.13 ? Doesn't look like there has been any change to AppEngine policy. |
AppEngine has changed. This can be fixed now. |
Great, thanks ! |
This is done now. The CL was just marked as merged as the change was already in effect. |
Relevant issue has been fixed: golang/go#19781
The
x/sync/errgroup/errgroup.go
file reads:it should probably import and use
"context"
instead of"golang.org/x/net/context"
(once AppEngine jumps to Go1.8)The text was updated successfully, but these errors were encountered: