Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: assist with cherry picks based on Milestones #19776

Closed
bradfitz opened this issue Mar 30, 2017 · 2 comments
Closed

x/build/cmd/gopherbot: assist with cherry picks based on Milestones #19776

bradfitz opened this issue Mar 30, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

As @rsc writes:

How about this. A bot watches issues in point release milestones. If such an issue is auto-closed due to a 'Fixes' commit on master, the bot says to itself "aha this hasn't been cherry-picked yet" and automatically reopens the issue with a 1-line comment "Reopening: CL xxxxx is not on release branch." Similarly, when the eventual cherry-pick does get committed to the release branch (which does not auto-close the issue), the bot comes along and closes the issue with another 1-line comment "Closing: CL xxxxx cherry-picked to release-branch as CL xxxxx." Bonus points for markdown links around [CL xxxxx].

Given this, when an issue comes in, you look into fixing it. If at some point (either before or after you fix it), you notice that it should be applied to a point release, you simply change the milestone to be the point release. The bot then takes care of reopening/closing as needed to make sure it goes into that point release. That seems pretty foolproof as a tracking mechanism.

Do that.
@bradfitz bradfitz self-assigned this Mar 30, 2017
@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 30, 2017
@gopherbot
Copy link

CL https://golang.org/cl/39352 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Apr 18, 2017
@bradfitz
cmd/gopherbot: mention gerrit CLs on Github (cl2issue port)
1eecef3 
This adds indexing of Github mentions to maintner, then adds gopherbot
functionality to say "CL https://golang.org/cl/NNNN mentions this issue."
on Github when a Gerrit CL references it.

Also the start of the cherry-pick milestone bot which needs the same
Github issue reference tracking. But that part's only barely started
and still disabled.

Fixes golang/go#18818
Updates golang/go#19776

Change-Id: Ie5f7f6845317a7c39cc36d7397c7539bf99c3f92
Reviewed-on: https://go-review.googlesource.com/39352
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@ALTree
Copy link
Member

ALTree commented Sep 22, 2018

This is no longer a problem with the new workflow, since we no longer manually put issue in minor milestones, but we ask gopherbot to open new backports issues. Closing here.

@ALTree ALTree closed this as completed Sep 22, 2018
@golang golang locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @ALTree @gopherbot