Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/owners: convert owners doc into a package #19757

Closed
rakyll opened this issue Mar 29, 2017 · 7 comments
Closed

x/build/owners: convert owners doc into a package #19757

rakyll opened this issue Mar 29, 2017 · 7 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@rakyll
Copy link
Contributor

rakyll commented Mar 29, 2017

We are planning to build a Gerrit assigner bot based on the package owners document at golang.org/s/owners. Convert this document into a package and enable bots and other programs can consume the data.

We should also make the owners package the source of truth, and generate a /s/owners page by using x/build/owners if a web listing is required.

/cc @jessfraz @spf13 @bradfitz

@rakyll rakyll added this to the Unreleased milestone Mar 29, 2017
@rakyll rakyll self-assigned this Mar 29, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 29, 2017
@bradfitz
Copy link
Contributor

That's one option. The other option is making the spreadsheet the source of truth and reading from it where needed.

Working with Go (and using Go code review tools and versioned history) is probably more consistent, though.

The dev.golang.org app could have an /owners page.

/cc @kevinburke @quentinmit

@rakyll
Copy link
Contributor Author

rakyll commented Mar 29, 2017

Rendering a page from this package will be quite trivial, and it will be possible to use Gerrit to open CLs to modify the owners data.

dev.golang.org/owners sounds great.

@kevinburke
Copy link
Contributor

(For what it's worth, as of today or thereabouts Github has begun adding "suggested reviewers" to pull requests in the sidebar, which suggests they also have thoughts about this problem and maybe some good ideas or data about how to solve it)

@rakyll
Copy link
Contributor Author

rakyll commented Mar 29, 2017

@kevinburke, there is already another issue for auto-assigning reviewers based on activity at #17555. Let's keep the conversation there. Our first step can be assigning based on the owners, we can always add more magic if there is a concrete proposal.

@gopherbot
Copy link

CL https://golang.org/cl/39390 mentions this issue.

@jessfraz
Copy link
Contributor

sweet, I added myself to be cc-ed on that CL so once it is in I can work on #17555

@ALTree
Copy link
Member

ALTree commented Sep 22, 2018

This is done (https://golang.org/x/build/devapp/owners) and reviewers are now automatically added, so I'm closing this issue.

@ALTree ALTree closed this as completed Sep 22, 2018
@golang golang locked and limited conversation to collaborators Sep 22, 2019
@rsc rsc unassigned rakyll Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

6 participants