Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: copy ParseDirent fixes from CL 23780 #19754

Closed
cespare opened this issue Mar 29, 2017 · 4 comments
Closed

x/sys/unix: copy ParseDirent fixes from CL 23780 #19754

cespare opened this issue Mar 29, 2017 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@cespare
Copy link
Contributor

cespare commented Mar 29, 2017

CL 23780 fixed unsafe use of unsafe in syscall.ParseDirent (see #15653). This patch never made it to x/sys/unix.

Side note: is there any automated process to ensure patches migrate from syscall to x/sys/unix? I had been moving all my code away from syscall, but this sort of thing makes me wonder if that's a bad idea because syscall might get more scrutiny than x/sys/unix.
@cespare cespare added this to the Unreleased milestone Mar 29, 2017
@bradfitz
Copy link
Contributor

Side note: is there any automated process to ensure patches migrate from syscall to x/sys/unix?

No, but with the latest progress in x/build/maintner it seems pretty easy to write a tool to find candidates that didn't get moved over. I'll write more about that tool ~next week. But on the other hand, there aren't too many such changes.

@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 29, 2017
@niconegoto
Copy link
Contributor

@cespare @bradfitz I can work on it.Should I wait for the automation process to be completed?

@bradfitz
Copy link
Contributor

@niconegoto, no, don't wait. Any automation would only find missing work, but not do the work.

@gopherbot
Copy link

CL https://golang.org/cl/38758 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @cespare @gopherbot @niconegoto