Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: remove likely/unlikely marks from assembly #19718

Closed
randall77 opened this issue Mar 25, 2017 · 1 comment
Closed

cmd/compile: remove likely/unlikely marks from assembly #19718

randall77 opened this issue Mar 25, 2017 · 1 comment
Milestone

Comments

@randall77
Copy link
Contributor

Conditional branches sometimes have a likely/unlikely bit attached to them.

	0x008c 00140 (s.go:7)	JLT	$0, 55

$0 means the branch is unlikely, $1 means the branch is likely.
There's really no reason why the assembly output should show these. It's an artifact of instruction reordering in the obj library that is now gone. We should just stop setting these marks when generating Progs.

See #15837

@randall77 randall77 added this to the Go1.9 milestone Mar 25, 2017
@randall77 randall77 self-assigned this Mar 25, 2017
@gopherbot
Copy link

CL https://golang.org/cl/38664 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants