x/build: make trybots refuse to test a commit that's too old #19664
Comments
|
Where is the logic for the trybots? |
|
golang.org/x/build/cmd/coordinator in coordinator.go |
|
Beware of how you apply this logic to subrepos, because the latest commit can easily be N days old. |
|
CL https://golang.org/cl/39536 mentions this issue. |
|
I set it to 43800 minutes for a tryset's parent/parents, which is 30 days. |
|
Is this still relevant? I saw my name at the top of https://dev.golang.org/reviews with it attached to this, so I wanted to see if it still needs attention from me. The last comments on the review were mine. |
|
This would still be nice to have done, but it should be based on number of git commits back rather than time. Also, the CL above has merge conflicts and needs to be rebased. |
|
Gotcha. How many commits do you want to go back? Also, I know there was previously a discussion about the maintner package, is the current CL still the proper way to implement this change or does it now need to be made somewhere else?
Mike.
From: Brad Fitzpatrick [mailto:notifications@github.com]
Sent: Thursday, December 7, 2017 12:56 PM
To: golang/go <go@noreply.github.com>
Cc: Mike Lloyd <mike@reboot3times.org>; Comment <comment@noreply.github.com>
Subject: Re: [golang/go] x/build: make trybots refuse to test a commit that's too old (#19664)
This would still be nice to have done, but it should be based on number of git commits back rather than time.
Also, the CL above has merge conflicts and needs to be rebased.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#19664 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHMEsUyR7O5ERi7myqIR9GzzQlCRY1cYks5s-EK8gaJpZM4Ml8j_>.
|
|
I'm not sure. Too few and it's annoying. It might need to be some combination of N commits back and time back, and maybe whether the build was broken & fixed in the meantime, but that's kinda tricky. We could start with just something like it's okay to run trybots it's fewer than 10 commits old OR less than 5 days. But once it's older than 10 commits AND older than 5 days, then we make them rebase? We can adjust the thresholds later. |
|
Change https://golang.org/cl/170457 mentions this issue: |
Updates golang/go#19664 Updates golang/go#9858 Updates golang/go#30807 Change-Id: I378979e2745b4d34286a3a038161eb03148771e7 Reviewed-on: https://go-review.googlesource.com/c/build/+/170457 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Make trybots refuse to test a commit with a git parent over N commits or days old.
Related to but different than #9858
The text was updated successfully, but these errors were encountered: