Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: use FP-based frame zeroing outside of package runtime on plan9 #19650

Open
mdempsky opened this issue Mar 21, 2017 · 0 comments
Open

cmd/compile: use FP-based frame zeroing outside of package runtime on plan9 #19650

mdempsky opened this issue Mar 21, 2017 · 0 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Performance
Milestone
Unplanned

Comments

@mdempsky
Copy link
Member

In 039d455, we changed cmd/compile to avoid using DUFFZERO and other FP-based frame zeroing methods, because they're not permitted within note handlers.

I think this is overly conservative. It should still be safe to use DUFFZERO on plan9 when we're compiling non-runtime packages, because functions from those packages will never be called by sigtramp. This is probably as simple as changing

var isPlan9 = obj.GOOS == "plan9"

to

var isPlan9 = obj.GOOS == "plan9" && compiling_runtime

in cmd/compile/internal/amd64/ggen.go.

Just pointing out since I was looking at related code. Will let some of the plan9 folks decide if this is worth pursuing.

/cc @0intro
@mdempsky mdempsky added this to the Unplanned milestone Mar 21, 2017
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
@rsc rsc mentioned this issue Mar 15, 2023
Closed
@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@bradfitz @mdempsky @bcmills @gopherbot