Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: GOTRACEBACK=crash doesn't print user stack for threads on system stack (backport) #19637

Closed
aclements opened this issue Mar 21, 2017 · 4 comments
Closed

runtime: GOTRACEBACK=crash doesn't print user stack for threads on system stack (backport) #19637

aclements opened this issue Mar 21, 2017 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.8.1

Comments

@aclements
Copy link
Member

https://golang.org/cl/38012 fixes #19494.
@aclements aclements added this to the Go1.8.1 milestone Mar 21, 2017
@gopherbot
Copy link

CL https://golang.org/cl/39600 mentions this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Apr 5, 2017

Is this worthy of a backport? It doesn't appear to be a regression from Go 1.7? At least #19494 doesn't say so.

Ask @rsc if he's sitting there.

@aclements
Copy link
Member Author

It's not a regression, but it has interfered with debugging runtime issues in 1.8. The fix is trivial and obviously correct (though the test is mighty hairy).

@aclements
Copy link
Member Author

Cherry-picked to release.

gopherbot pushed a commit that referenced this issue Apr 5, 2017
@aclements
[release-branch.go1.8] runtime: print user stack on other threads dur…
ff5695d 
…ing GOTRACBEACK=crash

Currently, when printing tracebacks of other threads during
GOTRACEBACK=crash, if the thread is on the system stack we print only
the header for the user goroutine and fail to print its stack. This
happens because we passed the g0 to traceback instead of curg. The g0
never has anything set in its gobuf, so traceback doesn't print
anything.

Fix this by passing _g_.m.curg to traceback instead of the g0.

Fixes #19494.
Fixes #19637 (backport).

Change-Id: Idfabf94d6a725e9cdf94a3923dead6455ef3b217
Reviewed-on: https://go-review.googlesource.com/39600
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz bradfitz changed the title runtime: backport CL 38012 to 1.8.1 runtime: GOTRACEBACK=crash doesn't print user stack for threads on system stack (backport) Apr 7, 2017
@golang golang locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8.1
Development

No branches or pull requests
3 participants
@bradfitz @aclements @gopherbot