Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerCancelsReadTimeoutWhenIdle flake on linux-amd64-race #19608

Closed
josharian opened this issue Mar 19, 2017 · 4 comments
Closed

net/http: TestServerCancelsReadTimeoutWhenIdle flake on linux-amd64-race #19608

josharian opened this issue Mar 19, 2017 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.10

Comments

@josharian
Copy link
Contributor

Seen on a trybot run:

--- FAIL: TestServerCancelsReadTimeoutWhenIdle (0.32s)
	serve_test.go:5111: Get http://127.0.0.1:38397: http: server closed idle connection
2017/03/19 00:55:14 http: TLS handshake error from 127.0.0.1:58706: read tcp 127.0.0.1:37994->127.0.0.1:58706: use of closed file or network connection
2017/03/19 00:55:14 http2: server: error reading preface from client 127.0.0.1:51512: read tcp 127.0.0.1:45423->127.0.0.1:51512: use of closed file or network connection
FAIL
FAIL	net/http	10.648s

https://storage.googleapis.com/go-build-log/901859c0/linux-amd64-race_be98d0fb.log
@josharian josharian added Builders x/build issues (builders, bots, dashboards) Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 19, 2017
@josharian josharian added this to the Go1.9 milestone Mar 19, 2017
@bradfitz
Copy link
Contributor

And a different variant:
https://storage.googleapis.com/go-build-log/9b8906b4/linux-amd64-race_05e3a2f0.log

@bradfitz bradfitz changed the title build: net/http TestServerCancelsReadTimeoutWhenIdle flake on linux-amd64-race net/http: TestServerCancelsReadTimeoutWhenIdle flake on linux-amd64-race Jun 28, 2017
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 28, 2017
@bradfitz
Copy link
Contributor

Another:
https://storage.googleapis.com/go-build-log/baa28ca2/linux-amd64-race_6ec8ee17.log

@bradfitz bradfitz self-assigned this Jul 15, 2017
@broady broady modified the milestones: Go1.9Maybe, Go1.9 Jul 17, 2017
@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.10 Jul 20, 2017
@orivej
Copy link

orivej commented Nov 17, 2017

I'm seeing this fairly often, on amd64 linux and aarch64 linux.

orivej added a commit to NixOS/nixpkgs that referenced this issue Nov 17, 2017
@orivej
go_1_9: skip flaky TestServerCancelsReadTimeoutWhenIdle
3ac474a 
golang/go#19608
https://hydra.nixos.org/build/64329767/nixlog/1
https://hydra.nixos.org/build/64244716/nixlog/1

Remove the patch for golang/go#21559 because it is
skipped as flaky since Go 1.9.2.
@gopherbot
Copy link

Change https://golang.org/cl/82595 mentions this issue: net/http: deflake TestServerCancelsReadTimeoutWhenIdle

finlay pushed a commit to dragonfly-science/nixpkgs that referenced this issue Apr 29, 2018
@orivej @finlay
go_1_9: skip flaky TestServerCancelsReadTimeoutWhenIdle
0db3566 
golang/go#19608
https://hydra.nixos.org/build/64329767/nixlog/1
https://hydra.nixos.org/build/64244716/nixlog/1

Remove the patch for golang/go#21559 because it is
skipped as flaky since Go 1.9.2.
@golang golang locked and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
5 participants
@bradfitz @broady @josharian @orivej @gopherbot