New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: chanrecv funcs don't actually use the *chantype parameter #19591
Comments
Also worth noting that |
The chantype is stored as a field in the hchan anyway. I think we can get rid of the parameters. Do you want to send a CL? |
Sure, I'll get on that.
So you mean get rid of it in |
Correct. |
Having some issues with panics, I'm likely missing some change to make the compiler and/or runtime fully aware of the new func signature. I'll post the CL on monday in any case, asking for pointers if I'm still stuck. |
Ah, found it - a missing |
CL https://golang.org/cl/38351 mentions this issue. |
The
t *chantype
parameter isn't actually used. I assume it could be removed, but the entry point magic scares me a bit and I don't dare do a CL myself.Unless the parameter is actually used/needed for a reason that's not obvious given the implementation?
Found with https://github.com/mvdan/unparam.
The text was updated successfully, but these errors were encountered: