Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) #19578

Closed
laboger opened this issue Mar 16, 2017 · 6 comments
Closed

cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) #19578

laboger opened this issue Mar 16, 2017 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8.1

Comments

@laboger
Copy link
Contributor

laboger commented Mar 16, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.8

What operating system and processor architecture are you using (go env)?

RH 7 ppc64le

I'd like to request a backport of https://go-review.googlesource.com/c/38131/ to go1.8. This patch is needed to fix a problem in the Kubernetes build when using go 1.8.
@bradfitz
Copy link
Contributor

bradfitz commented Mar 16, 2017 •
edited

(Original bug is #19425)

Sounds fine to me. @ianlancetaylor?

@bradfitz bradfitz added this to the Go1.8.1 milestone Mar 16, 2017
@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 16, 2017
@ianlancetaylor
Copy link
Contributor

SGTM

@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Mar 16, 2017
@cherrymui cherrymui mentioned this issue Mar 19, 2017
Closed
@laboger
Copy link
Contributor Author

laboger commented Mar 22, 2017

Sorry not sure of the process here, should I create a CL against go 1.8?

@ianlancetaylor
Copy link
Contributor

@laboger Sure, that would help. Thanks.

@gopherbot
Copy link

CL https://golang.org/cl/38472 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 23, 2017
@laboger @bradfitz
[release-branch.go1.8] cmd/link: put plt stubs first in Textp on ppc64x
d431307 
Previously call stubs were generated and inserted in
Textp after much of the text, resulting in calls too
far in some cases. This puts the call stubs first, which
in many cases makes some calls not so far, but also
enables trampolines to be generated when necessary.

This is a backport for go 1.8 based on CL38131.

Fixes #19578

Change-Id: If3ba3d5222a7f7969ed2de1df4854a1b4a80a0f0
Reviewed-on: https://go-review.googlesource.com/38472
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@aclements
Copy link
Member

Closing since committed to release branch.

@bradfitz bradfitz changed the title cmd/link: request backport of CL 38131 to go 1.8 cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) Apr 7, 2017
@golang golang locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8.1
Development

No branches or pull requests
5 participants
@bradfitz @aclements @ianlancetaylor @gopherbot @laboger