Skip to content

x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bradfitz opened this issue Mar 16, 2017 · 8 comments
Open

x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit #19572

bradfitz opened this issue Mar 16, 2017 · 8 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Have gopherbot ping a CL when it has +2 but OP can't submit.
@bradfitz bradfitz added this to the Unreleased milestone Mar 16, 2017
@bradfitz bradfitz self-assigned this Mar 16, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 21, 2017
@bradfitz
Copy link
Contributor Author

Temporary workaround: (search only works for people with sufficient Gerritt access)

https://go-review.googlesource.com/#/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%22approvers%22+AND+-ownerin:%22admins%22)

Gopherbot work is underway in http://golang.org/cl/38385

/cc @aclements @kevinburke

@bradfitz
Copy link
Contributor Author

GitHub seems to munge that URL. Let's try this:

https://go-review.googlesource.com/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%2522approvers%2522+AND+-ownerin:%2522admins%2522)

@bradfitz bradfitz changed the title x/build: have gopherbot ping a CL when it has +2 but OP can't submit x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit Mar 21, 2017
@bradfitz
Copy link
Contributor Author

@andybons, I was just discussing this bug with @robpike. Even if we fix this, it doesn't help Upspin or Perkeep, etc. This seems like something that Gerrit should just surface in the UI, to highlight when something is +2'ed (or otherwise submittable) but the Author doesn't have permission themselves to press Submit.

Could you file a Gerrit bug using the correct Gerrit terminology?

@andybons
Copy link
Member

https://bugs.chromium.org/p/gerrit/issues/detail?id=9247

@bradfitz
Copy link
Contributor Author

Gerrit changed and we can no longer do that query.

More motivation to fix this bug and do it ourselves.

/cc @dmitshur @bcmills

@bradfitz
Copy link
Contributor Author

I submited ACL change https://go-review.googlesource.com/c/All-Projects/+/178682 to let gopherbot have access to this info.

@bradfitz
Copy link
Contributor Author

... well, that didn't work. The only way I can get gopherbot to have access to query a group's members is to make gobot be an admin, which I'd rather not do.

@andybons, do you know which permissions/capabilities our gobot user needs to have in order to use https://godoc.org/golang.org/x/build/gerrit#Client.GetGroupMembers ?

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/178702 mentions this issue: cmd/gopherbot: add manual mode to dump who needs access

gopherbot pushed a commit to golang/build that referenced this issue May 30, 2019
@bradfitz
cmd/gopherbot: add manual mode to dump who needs access
f7a4c98 
Updates golang/go#19572

Change-Id: Ied3fc5f9e4c72eec5a65151f4d44f57119109367
Reviewed-on: https://go-review.googlesource.com/c/build/+/178702
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bradfitz bradfitz removed their assignment May 3, 2020
@bradfitz bradfitz added the FeatureRequest Issues asking for a new feature that does not need a proposal. label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @andybons @gopherbot