Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: SSA writebarrier implementation makes noopt build failed #19571

Closed
cherrymui opened this issue Mar 16, 2017 · 2 comments
Closed

cmd/compile: SSA writebarrier implementation makes noopt build failed #19571

cherrymui opened this issue Mar 16, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@cherrymui
Copy link
Member

https://build.golang.org/log/2e980b5ca706e6c48d6838ae9aa9158e59d5ed42

# runtime
runtime/cgo_sigaction.go:62:16: write barrier prohibited
runtime/cgocheck.go:42:14: write barrier prohibited
runtime/cgocheck.go:135:15: write barrier prohibited
runtime/mgcmark.go:245:15: write barrier prohibited
runtime/mgcmark.go:773:15: write barrier prohibited
runtime/mgcsweep.go:124:14: write barrier prohibited
runtime/signal_sighandler.go:30:22: write barrier prohibited
runtime/signal_unix.go:263:23: write barrier prohibited
runtime/signal_unix.go:313:22: write barrier prohibited
runtime/signal_unix.go:583:22: write barrier prohibited

I think this is because noopt makes a few optimization passes disabled and it cannot determine it doesn't need write barriers there.
@cherrymui cherrymui self-assigned this Mar 16, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Mar 16, 2017
@gopherbot
Copy link

CL https://golang.org/cl/38345 mentions this issue.

@cherrymui
Copy link
Member Author

Seems fixed with https://go-review.googlesource.com/c/38380/

@golang golang locked and limited conversation to collaborators Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @gopherbot @cherrymui