Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: requires CGO_ENABLED=1 #19569

Open
johanbrandhorst opened this issue Mar 16, 2017 · 9 comments
Open

plugin: requires CGO_ENABLED=1 #19569

johanbrandhorst opened this issue Mar 16, 2017 · 9 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Unplanned

Comments

@johanbrandhorst
Copy link
Member

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.8 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN="/home/johan/gows/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/johan/gows"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build464530147=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

I tried to build a simple plugin with CGO_ENABLED=0. It builds fine, and at plugin load time you get an error plugin: not implemented. This is an intentional limitation at the moment, but I think it moves backwards in the general trend of the language development, which has been moving away from C dependencies. This should hopefully be a discussion around supporting plugins without the need for CGO.

What did you expect to see?

I expected to be able to build and load plugins without CGO.

What did you see instead?

I got an error saying plugin: not implemented.
@bradfitz bradfitz changed the title Plugin use requires CGO_ENABLED=1 plugin: requires CGO_ENABLED=1 Mar 16, 2017
@bradfitz bradfitz added this to the Unplanned milestone Mar 16, 2017
@bradfitz
Copy link
Contributor

/cc @crawshaw @ianlancetaylor

@emilevauge emilevauge mentioned this issue Apr 5, 2017
Closed
@emilevauge
Copy link

emilevauge commented Apr 5, 2017 •
edited

Ouch, this one is really annoying as it prevents from using plugins with a statically linked golang executable (made for Docker containers).

@ianlancetaylor
Copy link
Contributor

The implementation of plugins requires the dynamic linker, so it will not work with statically linked executables. Changing that would be hard. There are no plans to do it.

@gopherbot
Copy link

CL https://golang.org/cl/43158 mentions this issue.

@odeke-em
Copy link
Member

I've mailed https://go-review.googlesource.com/43158 for starters.

@johanbrandhorst
Copy link
Member Author

Wouldn't this technically break the backwards compatibility promise? Since in 1.8 these builds compile fine with runtime errors.

@ianlancetaylor
Copy link
Contributor

As noted on the CL, I don't think preventing programs that import the plugin package from building is the right approach. And if we do think it is the right approach, we can do that by simply changing the plugin package to fail in some way when cgo is not available.

@emilevauge emilevauge mentioned this issue Jul 17, 2017
Closed
eraac added a commit to friendly-bot/plugins that referenced this issue Mar 27, 2018
@eraac
re-enable cgo golang/go#19569
3d417d1
@dturanski dturanski mentioned this issue Jun 6, 2018
Closed
@zloss zloss mentioned this issue Jun 27, 2018
Closed
@life1347 life1347 mentioned this issue Jul 5, 2018
Merged
@arjunrn arjunrn mentioned this issue Aug 31, 2018
Merged
@cp-i-pc cp-i-pc mentioned this issue Dec 1, 2018
Closed
@JesseGuoX JesseGuoX mentioned this issue Jan 4, 2019
Open
@steeve steeve mentioned this issue Feb 11, 2019
Closed
@oboukili oboukili mentioned this issue Aug 26, 2019
Closed
@wata727 wata727 mentioned this issue Nov 16, 2019
Merged
@danielnelson danielnelson mentioned this issue Feb 15, 2020
Closed
@Stebalien Stebalien mentioned this issue Jun 5, 2020
Closed
@mattysweeps mattysweeps mentioned this issue Jul 29, 2020
Closed
@invidian invidian mentioned this issue Sep 16, 2020
Open
@creack creack mentioned this issue Nov 25, 2020
Open
@mkanako mkanako mentioned this issue Feb 7, 2021
Closed
@cgrinds cgrinds mentioned this issue Jun 2, 2021
Closed
@tejal29 tejal29 mentioned this issue Aug 4, 2021
Merged
2 tasks
@konifar konifar mentioned this issue Sep 6, 2021
Closed
@1x-eng
Copy link

1x-eng commented Feb 19, 2022

Is there any update on this yet?

In the context of AWS Lambda, if CGO_ENABLED=1, GO lambda runs into these errors -

/var/task/main: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /var/task/main)
/var/task/main: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /var/task/main)

With CGO_ENABLED=0, the lambda is healthy, however, it cannot leverage/use a plugin. As posted by @johanbrandhorst , with CGO_ENABLED=0, using a plugin results in plugin: not implemented

@anakinkinsey
Copy link

@1x-eng I managed to run plugins in a lambda today without either of those errors. I did compile with CGO_ENABLED=1

@alexellis alexellis mentioned this issue Jul 1, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@ghost ghost mentioned this issue Aug 12, 2022
Merged
@seankhliao seankhliao mentioned this issue Apr 17, 2023
Closed
@teemukataja teemukataja mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
8 participants
@bradfitz @ianlancetaylor @odeke-em @emilevauge @johanbrandhorst @gopherbot @1x-eng @anakinkinsey