Skip to content

crypto/x509: TestSystemVerify failures on windows-*-2008 builders #19564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
josharian opened this issue Mar 15, 2017 · 18 comments
Closed

crypto/x509: TestSystemVerify failures on windows-*-2008 builders #19564

josharian opened this issue Mar 15, 2017 · 18 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@josharian
Copy link
Contributor

Seen on a trybot run for CL 38164:

--- FAIL: TestSystemVerify (45.44s)
verify_test.go:429: #7: unexpected error: x509: certificate signed by unknown authority
verify_test.go:438: #7: wanted 1 chains, got 0
FAIL
FAIL crypto/x509 46.342s

https://storage.googleapis.com/go-build-log/1d573555/windows-amd64-gce_8ca3ccb2.log

For that run, it failed on both amd64 and 386.
@josharian josharian added Builders x/build issues (builders, bots, dashboards) Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 15, 2017
@josharian josharian added this to the Go1.9Maybe milestone Mar 15, 2017
@bradfitz
Copy link
Contributor

Weird. Unless a system cert expired?

@josharian
Copy link
Contributor Author

But a subsequent run passed, with the same CL rebased up a single commit.

Maybe gce system clock flakiness?

@bradfitz
Copy link
Contributor

These are fresh VMs, single-use per build. Dunno.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Maybe Jul 20, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018
@mknyszek
Copy link
Contributor

Recent instance on windows-386 trybot?

##### Testing without libgcc.
--- FAIL: TestSystemVerify (0.95s)
    verify_test.go:565: #8: unexpected error: x509: certificate signed by unknown authority
    verify_test.go:574: #8: wanted 1 chains, got 0
FAIL
FAIL	crypto/x509	2.624s
2019/05/15 22:50:06 Failed: exit status 1
2019/05/15 22:50:07 FAILED

https://storage.googleapis.com/go-build-log/c197b9dc/windows-386-2008_583fee2b.log

@bcmills
Copy link
Contributor

bcmills commented Jun 19, 2019

windows-amd64-2008: https://build.golang.org/log/7b31163aedf5f508161c596b0ad2eddde8e41cd6

@bcmills
Copy link
Contributor

bcmills commented Jun 19, 2019

CC @FiloSottile

@bcmills
Copy link
Contributor

bcmills commented Jun 21, 2019

windows-386-2008: https://storage.googleapis.com/go-build-log/1ac503e8/windows-386-2008_3aa477de.log

@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2020

windows-386-2008: https://storage.googleapis.com/go-build-log/c5e2db69/windows-386-2008_f038f371.log

@bcmills
Copy link
Contributor

bcmills commented Jan 24, 2020

windows-386-2008 again: https://storage.googleapis.com/go-build-log/36722757/windows-386-2008_c181bd46.log

@bcmills
Copy link
Contributor

bcmills commented Mar 27, 2020

2020-03-27T14:49:08-dbd22c7/windows-386-2008

@bcmills bcmills changed the title crypto/x509: TestSystemVerify flake on windows crypto/x509: TestSystemVerify failures on windows builders Mar 27, 2020
@bcmills
Copy link
Contributor

bcmills commented Mar 27, 2020

CC @dmitshur @toothrot @cagedmantis @andybons

@bcmills bcmills changed the title crypto/x509: TestSystemVerify failures on windows builders crypto/x509: TestSystemVerify failures on windows-386-2008 builder Mar 27, 2020
@bcmills
Copy link
Contributor

bcmills commented Mar 27, 2020

Doesn't seem to have recurred on the amd64 builders.

@bcmills
Copy link
Contributor

bcmills commented Aug 21, 2020

https://storage.googleapis.com/go-build-log/6c3f4afd/windows-386-2008_d5db5165.log
https://storage.googleapis.com/go-build-log/212b5cf4/windows-386-2008_5f940be5.log

and many more today.

@cuonglm
Copy link
Member

cuonglm commented Aug 19, 2021

I faced one today https://storage.googleapis.com/go-build-log/d3c17d57/windows-386-2008_250c7d33.log

@bcmills
Copy link
Contributor

bcmills commented Sep 29, 2021

greplogs --dashboard -md -l -e 'FAIL: TestSystemVerify' --since=2020-08-21

2021-09-29T15:12:05-3f224bb/windows-386-2008
2021-08-17T21:34:32-a2a9a7b/windows-amd64-2008
2021-08-16T20:22:08-4466141/windows-386-2008
2021-08-13T20:45:17-98f3d7f/windows-amd64-2008
2021-06-30T17:58:50-7d0e9e6/windows-386-2008
2021-04-02T16:30:18-759116b/windows-386-2008
2021-03-17T17:13:50-0bd308f/windows-386-2008
2021-02-19T00:02:58-5ecd9e3/windows-amd64-2008

@bcmills bcmills changed the title crypto/x509: TestSystemVerify failures on windows-386-2008 builder crypto/x509: TestSystemVerify failures on windows-*-2008 builders Sep 29, 2021
@bcmills
Copy link
Contributor

bcmills commented Dec 8, 2021

greplogs --dashboard -md -l -e 'FAIL: TestSystemVerify' --since=2021-09-30

2021-12-08T21:21:44-9e29dd4/windows-amd64-2008

@bcmills
Copy link
Contributor

bcmills commented Dec 8, 2021

This is occasionally failing on windows/amd64 and windows/386, which are at least nominally first class ports. Marking as release-blocker for Go 1.18.

(However, since only the -2008 builders appear to be affected, I plan to address it by adding a skip to the test.)

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 8, 2021
@bcmills bcmills modified the milestones: Unplanned, Go1.18 Dec 8, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/370377 mentions this issue: crypto/x509: skip known TestSystemVerify flakes on windows-*-2008 builders

@golang golang locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
7 participants
@bradfitz @josharian @rsc @mknyszek @cuonglm @bcmills @gopherbot