You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The :1 in no_proxy should have been ::1, but a panic seems inappropriate in any case. Expected results would have been for the request to be proxied (as it did not match any no_proxy entries) or, possibly, return an error indicating that the proxy configuration couldn't be determined.
go version go1.8 darwin/amd64, same problem also present in go1.7.4 so it's not a regression in 1.8.
The text was updated successfully, but these errors were encountered:
bradfitz
changed the title
http: ProxyFromEnvironment panics on malformed no_proxy contents
net/http: ProxyFromEnvironment panics on malformed no_proxy contents
Mar 14, 2017
In Go 1.8, the following example program:
panics on a
no_proxy
containing a malformed entry:The
:1
inno_proxy
should have been::1
, but a panic seems inappropriate in any case. Expected results would have been for the request to be proxied (as it did not match anyno_proxy
entries) or, possibly, return an error indicating that the proxy configuration couldn't be determined.go version go1.8 darwin/amd64, same problem also present in go1.7.4 so it's not a regression in 1.8.
The text was updated successfully, but these errors were encountered: