Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/base32: add unpadded encodings like in base64 #19478

Closed
davidlazar opened this issue Mar 9, 2017 · 3 comments
Closed

encoding/base32: add unpadded encodings like in base64 #19478

davidlazar opened this issue Mar 9, 2017 · 3 comments
Labels
FrozenDueToAge help wanted Proposal-Accepted
Milestone
Go1.9

Comments

@davidlazar
Copy link
Member

The encoding/base64 package has unpadded encodings as of 2e0a1a7. I'd find it useful to have padding-free base32 encodings.
@rsc
Copy link
Contributor

rsc commented Mar 13, 2017

I don't see any reason they should be inconsistent.

@rsc rsc added this to the Go1.9 milestone Mar 13, 2017
@rsc
Copy link
Contributor

rsc commented Mar 13, 2017

CL welcome.

@rsc rsc changed the title proposal: unpadded base32 encodings encoding/base32: add unpadded encodings like in base64 Mar 13, 2017
zegl added a commit to zegl/go that referenced this issue Mar 24, 2017
@zegl
encoding/base32: unpadded and custom padded encodings
4ef556e 
Fixes: golang#19478

Change-Id: I87c76609d652bb8f478d16963223bb6f6a0e2d3a
@gopherbot
Copy link

CL https://golang.org/cl/38634 mentions this issue.

tmthrgd added a commit to tmthrgd/go-bindata that referenced this issue Apr 15, 2017
@tmthrgd
Add TODO for upstream unpadded base32 encoding
65c5650 
The encoding/base32 package currently lacks unpadded encoding. At
present the padding is removed with a call to strings.TrimSuffix.

Supoprt for unpadded encoding has been marked as Proposal-Accepted
in golang/go#19478 with milestone go1.9. Once that lands in a
release, the call to strings.TrimSuffix should be eliminated.

[ci skip]
@golang golang locked and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted Proposal-Accepted
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@davidlazar @rsc @gopherbot