-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: sweep increased allocation count #19473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
The following program can reproduce the issue:
run with:
crash:
|
Bisecting shows that it's introduced by commit c026845 |
@aclements, I'll let you either keep this or dup it into #19468 or #19029 as you wish. I don't see how a database/sql change (c026845) can cause runtime crashes, unless the compiler is getting something wrong and that change just happens to tickle it. |
@rasky I'll give it a try. And I found that it's context.cancelCtx.cancel that trigger the crash: https://github.com/golang/go/blob/master/src/context/context.go#L367. But I'm not able to make a reproduce with context yet. |
/cc @randall77 as author of the commit causing regression |
This is probably a dup of #19078. |
#19078 has been fixed - can someone check whether this issue is fixed on tip? |
It's fixed. |
What did you do?
ran a data-collecting program
What did you expect to see?
no crash
What did you see instead?
crash
System details
The text was updated successfully, but these errors were encountered: