Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: TestGuru failing #19464

Closed
bradfitz opened this issue Mar 8, 2017 · 6 comments
Closed

x/tools/cmd/guru: TestGuru failing #19464

bradfitz opened this issue Mar 8, 2017 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.9Early

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Mar 8, 2017

TestGuru is failing at tip:

https://build.golang.org/log/2b066d7aae1487ec9bfa0afe6706abd78074dcac

testdata/src/softerrs/main.go:8:6: i declared but not used
--- FAIL: TestGuru (49.07s)
	guru_test.go:286: Guru tests for testdata/src/describe/main.go failed: exit status 1.
		--- testdata/src/describe/main.golden	2017-03-06 19:49:08.000000000 -0800
		+++ testdata/src/describe/main.got	2017-03-08 14:10:03.000000000 -0800
		@@ -14,11 +14,11 @@
		 	const pie    cake = 3.141
		 
		 -------- @describe badimport1 --------
		+import of package "nosuchpkg"
		 
		-Error: can't import package "nosuchpkg"
		 -------- @describe badimport2 --------
		+reference to package "nosuchpkg"
		 
		-Error: can't import package "nosuchpkg"
		 -------- @describe unsafe --------
		 import of package "unsafe"
		 	builtin Alignof 
		
	guru_test.go:286: Guru tests for testdata/src/definition-json/main.go failed: exit status 1.
		--- testdata/src/definition-json/main.golden	2017-03-06 19:49:08.000000000 -0800
		+++ testdata/src/definition-json/main.got	2017-03-08 14:10:09.000000000 -0800
		@@ -53,8 +53,10 @@
		 
		 Error: couldn't find declaration of Nonesuch in "lib"
		 -------- @definition qualified-nopkg --------
		-
		-Error: no object for identifier
		+{
		+	"objpos": "testdata/src/definition-json/main.go:12:2",
		+	"desc": "package nosuchpkg"
		+}
		 -------- @definition select-field --------
		 {
		 	"objpos": "testdata/src/definition-json/main.go:40:16",
		
FAIL
FAIL	golang.org/x/tools/cmd/guru	49.109s

This is preventing use of trybots in the x/tools repo. Please fix.

/cc @griesemer @alandonovan
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 8, 2017
@bradfitz bradfitz added this to the Go1.9Early milestone Mar 8, 2017
@bradfitz
Copy link
Contributor Author

bradfitz commented Mar 8, 2017

The test is also super slow. 49 seconds is too slow for a short test.

@bradfitz
Copy link
Contributor Author

bradfitz commented Mar 8, 2017

And after skipping the failing test cases, it also has log spam:

$ go test -v -short
=== RUN   TestIssue17515
--- PASS: TestIssue17515 (0.00s)
=== RUN   TestGuru
testdata/src/softerrs/main.go:8:6: i declared but not used
--- PASS: TestGuru (47.92s)
=== RUN   TestIssue14684
--- PASS: TestIssue14684 (0.00s)
PASS
ok      golang.org/x/tools/cmd/guru     47.974s

@gopherbot
Copy link

CL https://golang.org/cl/37949 mentions this issue.

@bradfitz
Copy link
Contributor Author

New test failures at tip:

testdata/src/softerrs/main.go:8:6: i declared but not used
--- FAIL: TestGuru (51.44s)
	guru_test.go:293: Guru tests for testdata/src/imports/main.go failed: exit status 1.
		--- testdata/src/imports/main.golden	2017-04-13 11:26:28.000000000 -0700
		+++ testdata/src/imports/main.got	2017-04-13 11:32:00.000000000 -0700
		@@ -1,9 +1,11 @@
		 -------- @describe ref-pkg-import2 --------
		 import of package "hash/fnv"
		-	func  New32  func() hash.Hash32
		-	func  New32a func() hash.Hash32
		-	func  New64  func() hash.Hash64
		-	func  New64a func() hash.Hash64
		+	func  New128  func() hash.Hash
		+	func  New128a func() hash.Hash
		+	func  New32   func() hash.Hash32
		+	func  New32a  func() hash.Hash32
		+	func  New64   func() hash.Hash64
		+	func  New64a  func() hash.Hash64
		 
		 -------- @describe ref-pkg-import --------
		 import of package "lib"
		
FAIL
FAIL	golang.org/x/tools/cmd/guru	51.469s

Can we please make these tests hermetic and not depends on $GOROOT state?

@gopherbot
Copy link

CL https://golang.org/cl/40850 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Apr 14, 2017
@bradfitz
cmd/guru: disable a failing test for now
2a4809d 
Updates golang/go#19464

Change-Id: I60a77bc25aa8d92c4f2fc1835d96002ea5b8bfea
Reviewed-on: https://go-review.googlesource.com/40850
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
@bradfitz
Copy link
Contributor Author

bradfitz commented May 3, 2017

Dashboard looks happy.

@bradfitz bradfitz closed this as completed May 3, 2017
@golang golang locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.9Early
Development

No branches or pull requests
3 participants
@bradfitz @alandonovan @gopherbot