time: TestParseInLocation fail #19457

reusee · 2017-03-08T14:00:29Z

What did you do?

cd src/time
go test

What did you expect to see?

test pass

What did you see instead?

--- FAIL: TestParseInLocation (0.00s)
	format_test.go:264: ParseInLocation(Feb 01 2013 AST, Baghdad) = 2013-02-01 00:00:00 +0000 AST, want 2013-02-01 00:00:00 +0300 +03
FAIL
exit status 1
FAIL	time	8.438s

System details

go version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 linux/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/reus"
GORACE=""
GOROOT="/home/reus/go"
GOTOOLDIR="/home/reus/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build381570872=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 X:framepointer
uname -sr: Linux 4.9.11-1-ARCH
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.24, by Roland McGrath et al.
gdb --version: GNU gdb (GDB) 7.12.1

The text was updated successfully, but these errors were encountered:

ALTree · 2017-03-08T14:15:45Z

Here we go again.

The tzdata 2017a release changed the Baghdad abbreviation:

Changes to past and future time zone abbreviations
[..]
Similarly, switch from invented to numeric time zone
abbreviations for [..] Iraq [..]

We'll need to update the test, I'll send a patch.

ianlancetaylor · 2017-03-08T15:15:28Z

Setting milestone to 1.8.1. If I understand this, this is going to have to ripple back through all the previous releases.

gopherbot · 2017-03-09T13:30:37Z

CL https://golang.org/cl/37964 mentions this issue.

gopherbot · 2017-03-09T18:35:12Z

CL https://golang.org/cl/37991 mentions this issue.

The tzdata 2017a update (2017-02-28) changed the abbreviation of the Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the numeric '+03'. Update the test so that it skips the checks if we're using a recent tzdata release. Fixes #19457 Change-Id: I45d705a5520743a611bdd194dc8f8d618679980c Reviewed-on: https://go-review.googlesource.com/37964 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 91563ce) Reviewed-on: https://go-review.googlesource.com/37991 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

gopherbot · 2017-04-04T14:34:46Z

CL https://golang.org/cl/39470 mentions this issue.

This is a backport of https://golang.org/cl/37964 from the gc toolchain. Original description: The tzdata 2017a update (2017-02-28) changed the abbreviation of the Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the numeric '+03'. Update the test so that it skips the checks if we're using a recent tzdata release. Updates golang/go#19457 Fixes GCC PR 80302. Change-Id: Id3fc522ae16569f9d6b416f44f1ff9639d460626 Reviewed-on: https://go-review.googlesource.com/39470 Reviewed-by: Than McIntosh <thanm@google.com>

time: make the ParseInLocation test more robust This is a backport of https://golang.org/cl/37964 from the gc toolchain. Original description: The tzdata 2017a update (2017-02-28) changed the abbreviation of the Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the numeric '+03'. Update the test so that it skips the checks if we're using a recent tzdata release. Updates golang/go#19457 Fixes GCC PR 80302. Reviewed-on: https://go-review.googlesource.com/39470 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@246695 138bc75d-0d04-0410-961f-82ee72b054a4

gopherbot · 2017-09-25T18:40:34Z

Change https://golang.org/cl/66073 mentions this issue: [release-branch.go1.4] time: Skip TestParseInLocation test.

This test is now failing due to tz data updates (see issue #19457) - skip the test since it does not impact the use of Go 1.4 for bootstrapping. Similar to issue #17545. Updates #20672 Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d Reviewed-on: https://go-review.googlesource.com/66073 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This test is now failing due to tz data updates (see issue golang#19457) - skip the test since it does not impact the use of Go 1.4 for bootstrapping. Similar to issue golang#17545. Updates golang#20672 Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d Reviewed-on: https://go-review.googlesource.com/66073 Reviewed-by: Ian Lance Taylor <iant@golang.org>

maximlomans · 2018-07-03T00:07:20Z

FAIL: TestParseInLocation compile go1.5 on armv7 using go1.4 bootstrap

What version of Go are you using (`go version`)?

1.4 bootstrap

Does this issue reproduce with the latest release?

1.5 src

What operating system and processor architecture are you using (`go env`)?

raspbian armv7l pi3 - 4.4.50-hypriotos-v7+

What did you do?

followed Dave Cheney's advice set ulimits added swap space even cleared page cache before compiling had a clear 600M ram and 1023 swap free

$ cd go/src
$ env GO_TEST_TIMEOUT_SCALE=10 GOROOT_BOOTSTRAP=$HOME/go-linux-arm-bootstrap ./all.bash

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

success exit status 0 :)

What did you see instead?

ok text/template/parse 0.141s
--- FAIL: TestParseInLocation (0.02s) : p
format_test.go:202: ParseInLocation(Feb 01 2013 AST, Baghdad) = 2013-02-01 00:00:00 +0000 AST, want 2013-02-01 00:00:00 +0300 +03
--- FAIL: TestLoadFixed (0.01s)
time_test.go:943: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL time 5.582s
ok unicode 0.027s
ok unicode/utf16 0.021s
ok unicode/utf8 0.062s
ok cmd/addr2line 13.514s
ok cmd/api 0.065s
ok cmd/asm/internal/asm 0.274s
ok cmd/asm/internal/lex 0.027s
ok cmd/compile/internal/big 87.227s
ok cmd/cover 25.510s
ok cmd/doc 0.335s
ok cmd/fix 0.130s
ok cmd/go 301.585s
ok cmd/gofmt 1.007s
ok cmd/internal/goobj 0.018s
ok cmd/internal/obj 0.018s
ok cmd/internal/obj/x86 0.275s
ok cmd/internal/rsc.io/arm/armasm 0.069s
ok cmd/internal/rsc.io/x86/x86asm 3.826s
ok cmd/nm 14.115s
ok cmd/objdump 37.316s
ok cmd/pack 28.801s
ok cmd/pprof/internal/profile 0.067s
ok cmd/vet 51.834s
2018/07/03 01:30:39 Failed: exit status 1

ianlancetaylor · 2018-07-03T00:32:00Z

@marxenegls This issue was closed long ago. Go 1.5 is no longer supported.

maximlomans · 2018-07-03T00:35:53Z

fixed i skipped the tests used ./make.bash
i wasn't aware , .. if i were i would'av avoided the issue the begin with.

maximlomans · 2018-07-03T11:39:44Z

@ianlancetaylor " This issue was closed long ago. Go 1.5 is no longer supported."
closed long ago ? there are two open remarks ..
well technically this issue is an old one not fixed .. from your reply i presumed i was using both an old tutt (https://dave.cheney.net/2015/09/04/building-go-1-5-on-the-raspberry-pi) and an older version of Go .. which was not exactly the case but i had to find that out for myself .. trying to build 1.10 on arm was a futile attempt ..so maybe you aren't aware of what runs on arm at this point in time ..
miscommunication ..
and i keep making the same mistake in presuming the latest version is somehow better

ianlancetaylor · 2018-07-03T13:31:25Z

If the latest version (1.10.3) does not build on ARM, please file an issue about that. We don't support 1.5 but we do support 1.10 (and 1.9).

davecheney · 2018-07-08T00:33:23Z

It's unlikely that ./all.bash will complete successfully on a stock raspberry pi, but ./make.bash should complete successfully, and using the tarball provided on golang.org you can skip that process entirely.

…

On 3 July 2018 at 23:31, Ian Lance Taylor ***@***.***> wrote: If the latest version (1.10.3) does not build on ARM, please file an issue about that. We don't support 1.5 but we do support 1.10 (and 1.9). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#19457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA6fbjgp4sMMQE8_TnKAXbMBc2xIPks5uC3I6gaJpZM4MW0Gm> .

This test is now failing due to tz data updates (see issue golang#19457) - skip the test since it does not impact the use of Go 1.4 for bootstrapping. Similar to issue golang#17545. Updates golang#20672 Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d Reviewed-on: https://go-review.googlesource.com/66073 Reviewed-by: Ian Lance Taylor <iant@golang.org>

The tzdata 2017a update (2017-02-28) changed the abbreviation of the Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the numeric '+03'. Update the test so that it skips the checks if we're using a recent tzdata release. Fixes golang#19457 Change-Id: I45d705a5520743a611bdd194dc8f8d618679980c Reviewed-on: https://go-review.googlesource.com/37964 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

ALTree added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Mar 8, 2017

ALTree added this to the Go1.9 milestone Mar 8, 2017

ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. and removed Documentation labels Mar 8, 2017

ianlancetaylor modified the milestones: Go1.8.1, Go1.9 Mar 8, 2017

gopherbot closed this as completed in 91563ce Mar 9, 2017

sknigh mentioned this issue Apr 11, 2017

go-bootstrap build failure in Centos 7 spack/spack#3796

Closed

ehrt74 mentioned this issue Apr 3, 2018

failing tests 4ad/go#37

Open

tildeleb mentioned this issue Jun 11, 2018

doc: clarify fetching Go 1.4 from git #25816

Closed

golang locked and limited conversation to collaborators Jul 8, 2019

gopherbot added the FrozenDueToAge label Jul 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

time: TestParseInLocation fail #19457

time: TestParseInLocation fail #19457

reusee commented Mar 8, 2017

ALTree commented Mar 8, 2017 •

edited

ianlancetaylor commented Mar 8, 2017

gopherbot commented Mar 9, 2017

gopherbot commented Mar 9, 2017

gopherbot commented Apr 4, 2017

gopherbot commented Sep 25, 2017

maximlomans commented Jul 3, 2018

ianlancetaylor commented Jul 3, 2018

maximlomans commented Jul 3, 2018

maximlomans commented Jul 3, 2018

ianlancetaylor commented Jul 3, 2018

davecheney commented Jul 8, 2018 via email

time: TestParseInLocation fail #19457

time: TestParseInLocation fail #19457

Comments

reusee commented Mar 8, 2017

What did you do?

What did you expect to see?

What did you see instead?

System details

ALTree commented Mar 8, 2017 • edited

ianlancetaylor commented Mar 8, 2017

gopherbot commented Mar 9, 2017

gopherbot commented Mar 9, 2017

gopherbot commented Apr 4, 2017

gopherbot commented Sep 25, 2017

maximlomans commented Jul 3, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

ianlancetaylor commented Jul 3, 2018

maximlomans commented Jul 3, 2018

maximlomans commented Jul 3, 2018

ianlancetaylor commented Jul 3, 2018

davecheney commented Jul 8, 2018 via email

ALTree commented Mar 8, 2017 •

edited

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?