Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang.org: pop out link on sample code page shows error dialog box #19373

Closed
davecheney opened this issue Mar 2, 2017 · 6 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@davecheney
Copy link
Contributor

Reported on twitter

https://twitter.com/ZahoOnIT/status/837410479941300225

Confirmed locally

screen shot 2017-03-03 at 08 34 37

/cc @broady

@AlekSi
Copy link
Contributor

AlekSi commented Mar 6, 2017

Error in console:

Failed to load resource: the server responded with a status of 451 (HTTP/2.0 451) https://golang.org/share

@broady
Copy link
Contributor

broady commented Mar 6, 2017

Ah, that's a bummer. Need to do region checking for the homepage.

At the very least, show a better error message for 451.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/37881 mentions this issue.

@broady
Copy link
Contributor

broady commented Mar 7, 2017

Fixed (I cherry-picked 37881 into production while it's still pending).

@bradfitz bradfitz added this to the Go1.9 milestone Mar 21, 2017
@bradfitz
Copy link
Contributor

@broady, status here? Is that minus-twoed CL still in production?

@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 14, 2017
@broady
Copy link
Contributor

broady commented Jun 14, 2017

It is, but it needn't be.

I'll remove the cherry-pick in the (currently internal) deployment script and abandon CL 37881 after I verify the underlying cause has been fixed.

@broady broady closed this as completed Jun 14, 2017
@golang golang locked and limited conversation to collaborators Jun 14, 2018
@rsc rsc unassigned broady Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants