Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: report pkg/bin changes, binary size changes #19327

Open
josharian opened this issue Feb 28, 2017 · 2 comments
Open

x/build/cmd/coordinator: report pkg/bin changes, binary size changes #19327

josharian opened this issue Feb 28, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@josharian
Copy link
Contributor

It would be helpful when reviewing changes, particularly toolchain changes, to be able to easily see which pkg/bin files have changed since the parent commit--an easy reviewer's toolstash -cmp.

It'd also be nice to have an automated report about the pkg/bin file size changes.

Could we cheaply/easily add this information to the trybot final report?

cc @bradfitz

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Feb 28, 2017
@quentinmit
Copy link
Contributor

I'd like to cover this as part of per-commit benchmarks; we can have a fake benchmark that just reports the binary size.

Which binaries should we look at? Every executable file in the built go tree?

@josharian
Copy link
Contributor Author

I'd like to get these pre-commit, as part of the trybot result report message, as an aid in reviewing.

I had in mind something like this:

  • Artifacts are everything in the pkg dir and its subdirs: .a files and compiled tool executables.
  • For each artifact, strip its buildid.
  • Build a list of all artifacts that differ between commits.
  • Remove all items in that list who have a dependency on another item in the list. (If package strings has changed, lots of things will change. This will help reduce the impact of that.)
  • Report that list, or at least the first 10 items in it.
  • For the binary sizes, report size changes in cmd/go, cmd/compile, and cmd/fix. (The lattermost because its source code rarely changes and it is fairly small.)
  • Also report the size change of any file in the pkg dir whose size has changed more than 1%, sorted by amount of change, up to a max of 10.

I'm sure this would need tweaking over time. And some subset of the above would be helpful.

@josharian josharian added this to the Unreleased milestone Mar 1, 2017
@dmitshur dmitshur changed the title build: report pkg/bin changes, binary size changes x/build: report pkg/bin changes, binary size changes Jun 17, 2022
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 17, 2022
@dmitshur dmitshur changed the title x/build: report pkg/bin changes, binary size changes x/build/cmd/coordinator: report pkg/bin changes, binary size changes Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants