Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vendor/github.com/google/pprof: fix vet warnings #19322

Closed
josharian opened this issue Feb 28, 2017 · 10 comments
Closed

cmd/vendor/github.com/google/pprof: fix vet warnings #19322

josharian opened this issue Feb 28, 2017 · 10 comments
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@josharian
Copy link
Contributor

Here's a list:

cmd/vendor/github.com/google/pprof/driver/driver.go:44: cmd/vendor/github.com/google/pprof/internal/plugin.Options composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/addr2liner.go:167: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/addr2liner_llvm.go:124: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/addr2liner_llvm.go:147: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm.go:49: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/binutils_test.go:52: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:49: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:50: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:51: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:58: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:112: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/binutils/disasm_test.go:126: cmd/vendor/github.com/google/pprof/internal/plugin.Sym composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/driver/options.go:50: cmd/vendor/github.com/google/pprof/internal/symbolizer.Symbolizer composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go:76: cmd/vendor/github.com/google/pprof/internal/proftest.TestUI composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go:107: arg tc.want for printf verb %s of wrong type: cmd/vendor/github.com/google/pprof/internal/plugin.MappingSources
cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go:178: cmd/vendor/github.com/google/pprof/internal/proftest.TestUI composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/report/report_test.go:233: cmd/vendor/github.com/google/pprof/internal/graph.Graph composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:210: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:211: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:211: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:212: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:212: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:212: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:213: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:213: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:213: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:213: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:214: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:214: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:214: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:214: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go:214: cmd/vendor/github.com/google/pprof/internal/plugin.Frame composite literal uses unkeyed fields

When this is done, revert CL 37579.
@josharian josharian added this to the Go1.9 milestone Feb 28, 2017
@josharian
Copy link
Contributor Author

cc @rauls5382

@rauls5382
Copy link
Contributor

Looking into this. Will fix upstream

@rauls5382 rauls5382 mentioned this issue Feb 28, 2017
Merged
@gopherbot
Copy link

CL https://golang.org/cl/37617 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/37618 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 1, 2017
@bradfitz
cmd/vet/all: remove pprof from the whitelist
12b6c18 
Updates #19322

Change-Id: I610f40d874f499e52db3356a3da54538dac55242
Reviewed-on: https://go-review.googlesource.com/37618
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
@josharian
Copy link
Contributor Author

Re-opening. I still see these:

cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go:77: cmd/vendor/github.com/google/pprof/internal/proftest.TestUI composite literal uses unkeyed fields
cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go:179: cmd/vendor/github.com/google/pprof/internal/proftest.TestUI composite literal uses unkeyed fields

@josharian
Copy link
Contributor Author

Once fixed, re-revert CL 37625.

I do also see a couple of passes in the misc/vetall builder, so something is also wrong with misc/vetall. I'll investigate that separately.

gopherbot pushed a commit that referenced this issue Mar 1, 2017
@josharian
Revert "cmd/vet/all: remove pprof from the whitelist"
9bd1cc3 
This reverts commit 12b6c18.

Reason for revert: Broke vet builder. #19322 was not fully fixed.

Change-Id: Id85131d4d0b8915480d65e3532da62b769463d70
Reviewed-on: https://go-review.googlesource.com/37625
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
@rauls5382
Copy link
Contributor

I'll fix these, but when I do "go vet github.com/google/pprof/..." I do not see these listed. Is there anything else I should be using to find these?

@josharian
Copy link
Contributor Author

Thanks, Raul, and sorry about that.

I'm not sure why your command doesn't bring them up. I found them with:

cd cmd/vet/all
go run main.go

that runs under the hood:

go install <pkg>
go tool vet path/to/pkg

Does that help you reproduce?

@rauls5382 rauls5382 mentioned this issue Mar 1, 2017
Merged
@rauls5382
Copy link
Contributor

Not really, at head (on Mac OS):

$ pwd
/Users/rsilvera/github.com/golang/go/src/cmd/vet/all
$ ../../../../bin/go run main.go
go run main.go -p darwin/amd64
$

Will fix shortly anyway.

@gopherbot
Copy link

CL https://golang.org/cl/37652 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 1, 2017
@rauls5382 @bradfitz
cmd/vendor/github.com/google/pprof: refresh from upstream
a047f72 
Updating to commit dec22b42d9eee442222c36c8da24ddc9905e7ee6
from github.com/google/pprof

Fixes #19322.

Change-Id: I1bc3fcd381f22d52557f61c6fb694f54fc64470c
Reviewed-on: https://go-review.googlesource.com/37652
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@josharian @gopherbot @rauls5382