net/url: first path segment in URL cannot contain colon. #19297

shibingli · 2017-02-27T07:14:53Z

Description：

No Scheme, and the address format is ”IP: Port“ Address parsing failed.

OS Ver:
Mac OSX 10.12.3

Go Ver:
1.8

Go ENV:

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/shibingli/Develop/Go_Code/webconsole"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dy/lsbr_78131x3s9fjq15v8rg80000gn/T/go-build052845002=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

Code:

u, err := url.Parse("192.168.2.2:6688")
if nil != err {
       panic(err)
}
fmt.Println(u.Host, u.Port())

Error:

panic: parse 192.168.2.2:6688: first path segment in URL cannot contain colon

goroutine 1 [running]:
main.main()
	/Users/shibingli/Develop/Go_Code/webconsole/src/apibox.club/test/test.go:46 +0x138

Source:

https://github.com/golang/go/blob/release-branch.go1.8/src/net/url/url.go#L513

The text was updated successfully, but these errors were encountered:

davecheney · 2017-02-27T07:21:46Z

Working as intended I think. That is not a URL.

…

On 27 Feb 2017, at 18:14, Eric Shi ***@***.***> wrote: Description： No Scheme, and the address format is ”IP: Port“ Address parsing failed. OS Ver: Mac OSX 10.12.3 Go Ver: 1.8 Go ENV: GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/shibingli/Develop/Go_Code/webconsole" GORACE="" GOROOT="/usr/local/go" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dy/lsbr_78131x3s9fjq15v8rg80000gn/T/go-build052845002=/tmp/go-build -gno-record-gcc-switches -fno-common" CXX="clang++" CGO_ENABLED="1" PKG_CONFIG="pkg-config" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" Code: u, err := url.Parse("192.168.2.2:6688") if nil != err { panic(err) } fmt.Println(u.Host, u.Port()) Error: panic: parse 192.168.2.2:6688: first path segment in URL cannot contain colon goroutine 1 [running]: main.main() /Users/shibingli/Develop/Go_Code/webconsole/src/apibox.club/test/test.go:46 +0x138 Source: https://github.com/golang/go/blob/release-branch.go1.8/src/net/url/url.go#L513 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mattn · 2017-02-27T07:24:27Z

@davecheney

package main

import (
	"fmt"
	"net/url"
)

func main() {
	fmt.Println(url.Parse("www.google.com:443"))
	fmt.Println(url.Parse("192.168.1.2:443"))
}

www.google.com:443 <nil>
<nil> parse 192.168.1.2:443: first path segment in URL cannot contain colon

I don't make sure but it seems fail when the host is IP.

shibingli · 2017-02-27T07:34:08Z

@mattn I think you're right。
@davecheney www.google.com: 443 and 192.168.1.2:443 should be the same.

Golang 1.7 version can do so.

mattn · 2017-02-27T07:36:57Z

https://github.com/golang/go/blob/release-branch.go1.8/src/net/url/url.go#L500

www.google.com is treated as scheme at this line.

mattn · 2017-02-27T07:39:00Z

In my opinion, this is not a bug because rfc3986 allow to use dot in scheme.

mattn · 2017-02-27T07:49:43Z

@shibingli if you want to parse such string, please use url.Parse("//192.168.1.2:443") instead.

shibingli · 2017-02-27T07:55:50Z

@mattn Okay, I've done that. But I think it is normal to do that.

dsnet · 2017-02-27T07:58:35Z

Closing as working-as-intended. It could be documented better. That is #18824.
But @mattn is right. The correct way is //192.168.1.2:44. Read #18824 for details.

shibingli · 2017-02-27T08:10:07Z

@dsnet Thanks.

A change made to the net/url library in go 1.8 causes a panic when starting kontrol: panic: parse 127.0.0.1:4001: first path segment in URL cannot contain colon This is caused by the fact that net/url no longer considers "127.0.0.1:4001" a valid URL because the specification allows for dots in the schema-part of the URL. * golang/go#19297

henry3695 · 2017-09-02T02:16:05Z

u, err := url.Parse("//192.168.2.2:6688")
if nil != err {
panic(err)
}
fmt.Println(u.Host, u.Port())

very ok

kirichenko · 2017-09-19T10:14:41Z

ERROR: failed to parse http://ddmwebrevo.digdes.com/#/document/ca061121-8679-4afb-bf96-5aefdcac2dbf : parse http://ddmwebrevo.digdes.com/: first path segment in URL cannot contain colon

mattn · 2017-09-19T10:26:05Z

@kirichenko Could you please show your minimal code to reproduce?

kirichenko · 2017-09-20T09:33:05Z

I'm sorry. There was a typo in URL (space in the begining).

Go will fail to parse this otherwise. golang/go#19297

edwardstudy · 2018-01-05T09:35:28Z

Hi. I met the error: parse 127.0.0.1:65085/auth/v1.0/: first path segment in URL cannot contain colon. But 'localhost::65085/auth/v1.0/' was work.

smileboywtu · 2018-03-05T02:05:17Z

first path segment in URL cannot contain colon

here is the url:
http://zhidao.baidu.com/special/view?id=a9105a24626975510000&preview=1

is there something wrong

bradfitz · 2018-03-05T03:21:55Z

This is a closed issue. Closed issues aren't tracked.

For questions about Go, see https://golang.org/wiki/Questions.

shibingli changed the title ~~net/url: Parse 192.168.2.2:6688 , first path segment in URL cannot contain colon.~~ net/url: first path segment in URL cannot contain colon. Feb 27, 2017

dsnet closed this as completed Feb 27, 2017

mattn mentioned this issue Mar 30, 2017

net/url: "host:port" URLs interpreted as "scheme:opaque" #19779

Closed

travisofthenorth mentioned this issue Apr 2, 2017

Fix url parse error bitly/oauth2_proxy#365

Merged

n4ss mentioned this issue Jun 7, 2017

Force serverURL to have https protocol docker/docker-credential-helpers#55

Closed

danielnelson mentioned this issue Jun 8, 2017

inputs/mongodb not parsing configs influxdata/telegraf#2888

Closed

eikaas mentioned this issue Jun 23, 2017

Fixes breaking change done in net/url koding/kite#204

Merged

milesbxf mentioned this issue Aug 7, 2017

Cannot scrape URI on a different port sysulq/nginx-vts-exporter#25

Closed

dmjio added a commit to dmjio/nixpkgs that referenced this issue Oct 6, 2017

oauth2_proxy: default address updated

5b530d4

Go will fail to parse this otherwise. golang/go#19297

dmjio mentioned this issue Oct 6, 2017

oauth2_proxy: default address updated NixOS/nixpkgs#30173

Merged

8 tasks

golang locked and limited conversation to collaborators Mar 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net/url: first path segment in URL cannot contain colon. #19297

net/url: first path segment in URL cannot contain colon. #19297

shibingli commented Feb 27, 2017

davecheney commented Feb 27, 2017 via email

mattn commented Feb 27, 2017 •

edited

shibingli commented Feb 27, 2017 •

edited

mattn commented Feb 27, 2017

mattn commented Feb 27, 2017

mattn commented Feb 27, 2017 •

edited

shibingli commented Feb 27, 2017

dsnet commented Feb 27, 2017 •

edited

shibingli commented Feb 27, 2017

henry3695 commented Sep 2, 2017

kirichenko commented Sep 19, 2017

mattn commented Sep 19, 2017

kirichenko commented Sep 20, 2017

edwardstudy commented Jan 5, 2018 •

edited

smileboywtu commented Mar 5, 2018 •

edited

bradfitz commented Mar 5, 2018

net/url: first path segment in URL cannot contain colon. #19297

net/url: first path segment in URL cannot contain colon. #19297

Comments

shibingli commented Feb 27, 2017

davecheney commented Feb 27, 2017 via email

mattn commented Feb 27, 2017 • edited

shibingli commented Feb 27, 2017 • edited

mattn commented Feb 27, 2017

mattn commented Feb 27, 2017

mattn commented Feb 27, 2017 • edited

shibingli commented Feb 27, 2017

dsnet commented Feb 27, 2017 • edited

shibingli commented Feb 27, 2017

henry3695 commented Sep 2, 2017

kirichenko commented Sep 19, 2017

mattn commented Sep 19, 2017

kirichenko commented Sep 20, 2017

edwardstudy commented Jan 5, 2018 • edited

smileboywtu commented Mar 5, 2018 • edited

bradfitz commented Mar 5, 2018

mattn commented Feb 27, 2017 •

edited

shibingli commented Feb 27, 2017 •

edited

mattn commented Feb 27, 2017 •

edited

dsnet commented Feb 27, 2017 •

edited

edwardstudy commented Jan 5, 2018 •

edited

smileboywtu commented Mar 5, 2018 •

edited