Can all the chips we care about do store-to-load forwarding with mismatched sizes? Might be better to keep this out of the generic rules unless we are certain that they all can.

This come up often?

Can all the chips we care about do store-to-load forwarding with mismatched sizes? Might be better to keep this out of the generic rules unless we are certain that they all can.

Good point. I'm not even sure that amd64 handles this well. Moving to unplanned for now.

This come up often?

Haven't investigated.

Also, each additional rule incurs a cost - and it's not clear the cost here (extra check for this case at compile-time) will outweigh the benefit.

I've prototyped this as a target-specific rule, it triggers once during compilation, and provides no performance benefit for simple benchmark (calling top in a loop). I think this is not worth implementing.

Thanks for running it down, @TocarIP. Closing.

Not proposing to reopen this, but FWIW, this does occur in the hashmap implementation. Pulling the repeated tophash calculation into its own function for demo purposes:

func tophash(hash uintptr) uint8 {
	top := uint8(hash >> (sys.PtrSize*8 - 8))
	if top < minTopHash {
		top += minTopHash
	}
	return top
}

compiles to:

"".tophash STEXT nosplit size=21 args=0x10 locals=0x0
	0x0000 00000 (/Users/josh/go/src/runtime/hashmap.go:1044)	TEXT	"".tophash(SB), NOSPLIT, $0-16
	0x0000 00000 (/Users/josh/go/src/runtime/hashmap.go:1044)	FUNCDATA	$0, gclocals·f207267fbf96a0178e8758c6e3e0ce28(SB)
	0x0000 00000 (/Users/josh/go/src/runtime/hashmap.go:1044)	FUNCDATA	$1, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
	0x0000 00000 (/Users/josh/go/src/runtime/hashmap.go:1044)	MOVQ	"".hash+8(SP), AX
	0x0005 00005 (/Users/josh/go/src/runtime/hashmap.go:1045)	SHRQ	$56, AX
	0x0009 00009 (/Users/josh/go/src/runtime/hashmap.go:1046)	CMPB	AL, $4
	0x000b 00011 (/Users/josh/go/src/runtime/hashmap.go:1046)	JCC	16
	0x000d 00013 (/Users/josh/go/src/runtime/hashmap.go:1047)	ADDL	$4, AX
	0x0010 00016 (/Users/josh/go/src/runtime/hashmap.go:1049)	MOVB	AL, "".~r1+16(SP)
	0x0014 00020 (/Users/josh/go/src/runtime/hashmap.go:1049)	RET

The MOVQ/SHRQ at the beginning could just be a MOVB.