Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme/autocert: support ForceRSA as a per domain option #19265

Closed
phuslu opened this issue Feb 24, 2017 · 1 comment
Closed

x/crypto/acme/autocert: support ForceRSA as a per domain option #19265

phuslu opened this issue Feb 24, 2017 · 1 comment

Comments

@phuslu
Copy link

phuslu commented Feb 24, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.8

What did you expect to see?

Currently, autocert.Manager.ForceRSA is a global option for all domains. I expect it's a per domain option.
e.g.

type Manager struct {
	GetForceRSA func (domain string) bool
}

we can build multiple-domains https server with mixed RSA/ECC certificates base on this option.

@phuslu phuslu changed the title x/crypto/acme/autocert: support ForceRSA per domain x/crypto/acme/autocert: support ForceRSA as a per domain option Feb 24, 2017
@bradfitz
Copy link
Contributor

Sorry, this isn't an option I want to see added.

ForceRSA is a bit gross on its own. I don't think it needs more complication and configuration around it, especially since you can already wire it up yourself: just implement tls.Config.GetCertificate and delegate to two different Managers (one with true vs false) depending on the hostname.

I think that the number of users of such a feature would be low enough (and decreasing over time) to not warrant adding this complexity for everybody.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants