internal/poll: Changed error string breaks user application #19252
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version devel +3792db5 Mon Feb 13 18:36:28 2017 +0000 linux/amd64
It works on Go 1.8
What operating system and processor architecture are you using (
go env
)?What did you do?
make integration-test
for the code I am working on.go-gitea/gitea#741 (comment)
But I think that doesn't matter after all.
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
All tests passed.
What did you see instead?
All tests failed.
It turned out that one of the dependent libraries ( (See https://github.com/facebookgo/httpdown/blob/master/httpdown.go#L338) uses the exact error string to make its decision and the string in question was changed at some point of time (3792db5#diff-18782360650b1a2ccfee593591ff45bbR17). This may not be the fault of the error string changing but I'd like to know what the recommended solution (an idimatic way for differentiating errors) is for the case. And maybe the possible impact can be prepared before the next production release.
The text was updated successfully, but these errors were encountered: