cmd/go: Canonical paths should be enforced on vendored imports #19224
Labels
FrozenDueToAge
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Comments
|
Fix is here: https://go-review.googlesource.com/c/37371/ |
|
CL https://golang.org/cl/37371 mentions this issue. |
bradfitz
added
the
NeedsDecision
|
Leaving for @rsc. I'm not sure whether the current behavior is intentional. I guess not, though. |
|
It's intentional that the code doesn't complain that rsc.io/pdf is found in foo.com/vendor/rsc.io/pdf. It was not strictly intentional that it also doesn't complain about foo.com/vendor/github.com/rsc/pdf, but maybe that's OK too. Not sure. |
|
Every time I change the conditions under which this error triggers, it breaks someone. I am inclined to leave this alone. It's OK that we're not enforcing the import paths in the vendor dir: let's assume that's managed by a tool that knows what it's doing. In the long term we hope vendor dirs disappear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a package which vendors packages with Canonical Imports. Build worked fine when the imports were vendored but failed when the packages were moved into the GOPATH. This is because canonical import paths are not enforced on vendored packages.
What version of Go are you using (
go version)?From vendor support merging to latest master (a355639)
What did you do?
go build .What did you expect to see?
mypackage.go:8:2: code in directory $GOPATH/vendor/github.com/rsc/pdf expects import "rsc.io/pdf"
What did you see instead?
Nothing. (Command exited with success.)
The text was updated successfully, but these errors were encountered: