You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is purposefully one commit behind 1f77db9 and what we would see after we fix #19184.
$ go version
go version devel +8833af3f4b Wed Feb 15 21:14:37 2017 +0000 linux/amd64
In the runtime directory:
$ go test -a -short -gcflags '-l=4'
# runtime_test
./callers_test.go:8: cannot import "runtime" due to version skew - reinstall package (inconsistent definition for func runtime.memclrNoHeapPointers during import
func(*byte, uintptr)
func(unsafe.Pointer, uintptr))
FAIL runtime [build failed]
One potential solution is to mark MemclrBytes noinline, but it's not clear if that is the right long-term solution.
The text was updated successfully, but these errors were encountered:
The compiler thinks memclrNoHeapPointers has signature func(*byte, uintptr) (https://go.googlesource.com/go/+/master/src/cmd/compile/internal/gc/builtin/runtime.go#130), whereas the actual function in runtime has signature func(unsafe.Pointer, uintptr).
CL https://golang.org/cl/37257 changes the compiler's copy to match the runtime.
However, there are other functions marked as taking *byte or *any in the compiler, but actually takes a pointer to a specific runtime type, or arbitrary pointer type. There might be also problem if they get imported through inlining. Maybe we should let bimport's check allow this case?
This is purposefully one commit behind 1f77db9 and what we would see after we fix #19184.
In the runtime directory:
One potential solution is to mark
MemclrBytes
noinline, but it's not clear if that is the right long-term solution.The text was updated successfully, but these errors were encountered: