Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: support Darwin again #19167

Closed
krisnova opened this issue Feb 17, 2017 · 4 comments
Closed

plugin: support Darwin again #19167

krisnova opened this issue Feb 17, 2017 · 4 comments

Comments

@krisnova
Copy link

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.8 darwin/amd64

What did you do?

Tried to build a binary with -buildmode=plugin on Darwin

-buildmode=plugin not supported on darwin/amd64

This is a known limitation

As it stands today the Go documentation the plugin feature is only advertised on linux.

Currently plugins only work on Linux.

I am wondering if we could look at introducing native Darwin functionality for this feature as well? I know @crawshaw has done a lot of work on the existing plugin implementation. I also am interested in contributing to the project and wouldn't mind coding this myself (or helping out) if that was at all possible.

Thoughts?

@bradfitz bradfitz changed the title Extend plugin functionality to run on Darwin arch plugin: support Darwin again Feb 17, 2017
@bradfitz bradfitz added this to the Go1.9Maybe milestone Feb 17, 2017
@bradfitz
Copy link
Contributor

Actually, dup of #18104

@krisnova
Copy link
Author

@bradfitz is this actually a dup of #18104? I noticed your comment #18104 (comment)

I am wondering if that comment suggests working on Darwin support for 1.9? If so I think it's a dup.. but otherwise #18104 looks like another case.

@bradfitz
Copy link
Contributor

That was the main bug that prompted us to remove plugin support from darwin at the 11th hour. If/when that's fixed, we can reenable it.

@wmarbut
Copy link

wmarbut commented Oct 21, 2017

In the comments for #18104, it is stated that this is fixed at HEAD. I have can confirm that it now works on my OS 10.12.5 machine.

@golang golang locked and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants