Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gitmirror: support serving unsubmitted commits #19166

Closed
bradfitz opened this issue Feb 17, 2017 · 3 comments
Closed

x/build/cmd/gitmirror: support serving unsubmitted commits #19166

bradfitz opened this issue Feb 17, 2017 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge

Comments

@bradfitz
Copy link
Contributor

The gitmirror should support downloading the *.tar.gz of any commit digest, even if it's not known.

It should just "git fetch" it first.

Then the coordinator could use it even for try runs.
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Feb 17, 2017
@bradfitz bradfitz self-assigned this Feb 17, 2017
@bradfitz
Copy link
Contributor Author

@kevinburke, this one is probably higher priority than #11224

Right now we never use gitmirror for trybots since the mirror might not have the commit being tested. But that means the coordinator always gets the source from Gerrit, which doesn't support gitattributes at all (the temporary solution already done before #11224), which means the x/talks repo is 113 MB or so, and the limit is 50MB (just upped from 25MB). If we did this, at least we'd get trybots working for the talks repo again.

@kevinburke
Copy link
Contributor

OK, I'll take a look

@gopherbot
Copy link

CL https://golang.org/cl/37225 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Feb 22, 2017
@bradfitz
cmd/coordinator: use gitmirror for trybot runs also
88f4d73 
(been in production for past few days)

Updates golang/go#19166

Change-Id: Iee301aac5aa87c6644ac1253d7c0bd6c522ff066
Reviewed-on: https://go-review.googlesource.com/37380
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @kevinburke @gopherbot