Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/objdump: implement arm64 disassembler #19157

Closed
randall77 opened this issue Feb 17, 2017 · 15 comments
Closed

cmd/objdump: implement arm64 disassembler #19157

randall77 opened this issue Feb 17, 2017 · 15 comments
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@randall77
Copy link
Contributor

No description provided.

@bradfitz
Copy link
Contributor

I see that ARM released machine-readable architecture specs:

https://alastairreid.github.io/alastairreid.github.io/ARM-v8a-xml-release/

/cc @rsc @cherrymui

@bradfitz bradfitz modified the milestones: Go1.9Maybe, Unplanned Apr 21, 2017
@bradfitz
Copy link
Contributor

/cc @williamweixiao

@bradfitz
Copy link
Contributor

bradfitz commented Jun 7, 2017

@williamweixiao, is this happening for Go 1.9? It's looking pretty late, unless the work is already done and non-invasive to other ports.

@williamweixiao
Copy link
Member

@bradfitz I submitted the patch (https://go-review.googlesource.com/c/43651/) three weeks ago but still get no feedback. The patch is non-invasive to other ports and parts at all.

@cherrymui
Copy link
Member

A CL is submitted for x/arch. We can review and submit the CL to x/arch during the freeze. I don't think this will be in Go 1.9.

@bradfitz
Copy link
Contributor

bradfitz commented Jun 8, 2017

@cherrymui, I'm fine with this as a late addition if you can review these CLs. I'm a little sad we've let this sit so long.

I'm okay with it as a late addition because it's well isolated from everything else. There's very little risk.

@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. FeatureRequest labels Jun 8, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Jun 8, 2017

@randall77, maybe you can help review too?

@cherrymui
Copy link
Member

I thought it probably includes some new instructions (in CL https://go-review.googlesource.com/c/41654/) which will not go into Go 1.9, so this as well. But I may be wrong.

@williamweixiao
Copy link
Member

@cherrymui yes, it supports almost all armv8 instructions and is fully tested by comparing to GNU objdump output. As for Go syntax part, the basic instructions (include FP) are fully tested with assembler as inputs and we will add these tests into assembler soon. The only untested part is for the new instructions added by CL41654 since it has not been merged. But we'd like to keep this part and submit bug fixing patch if needed in the future because the decoder table is automatically generated by tool and it's hard to isolate new instructions.

@williamweixiao
Copy link
Member

The issue can be closed since the patch (CL 43651) has been merged.

@bradfitz
Copy link
Contributor

@williamweixiao, let's keep this open until it's vendored into std for Go 1.10.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Maybe Jul 13, 2017
@williamweixiao
Copy link
Member

When will it be vendored into go repo?
I need to submit another patch to "cmd/internal/objfile" for enabling arm64 disassembler to be used by other tools such as objdump and pprof.

@bradfitz
Copy link
Contributor

@williamweixiao, there is no automatic process that vendors this into the main go repo. It requires a human to do that manually, and it's nobody's job. It is done when needed, by whoever needs it. Feel free to send a change.

@gopherbot
Copy link

CL https://golang.org/cl/49530 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 16, 2017
Vendor from golang.org/x/arch (commit f185940).

Implements #19157

Updates #12840
Updates #20762
Updates #20897
Updates #20096
Updates #20766
Updates #20752
Updates #20096
Updates #19142

Change-Id: Idefb8ba2c355dc07f3b9e8dcf5f00173256a0f0f
Reviewed-on: https://go-review.googlesource.com/49530
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@gopherbot
Copy link

Change https://golang.org/cl/58930 mentions this issue: cmd/internal/objfile: add arm64 disassembler support

@golang golang locked and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants