Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: tests broken after #19150

Closed
bradfitz opened this issue Feb 17, 2017 · 5 comments
Closed

x/tools: tests broken after #19150

bradfitz opened this issue Feb 17, 2017 · 5 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.9

Comments

@bradfitz
Copy link
Contributor

The x/tools repo tests are broken as of c05b06a ("os: use poller for file I/O").

https://build.golang.org/?repo=golang.org%2fx%2ftools

@ianlancetaylor, can you look into it?

/cc @jayconrod @alandonovan
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 17, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Feb 17, 2017
@ianlancetaylor
Copy link
Contributor

Sorry, didn't check for subrepo breakage.

CL 37148.

@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 17, 2017 •
edited

Maybe trybots should tests certain weirdo tests like that.

But I'd prefer we don't have such weirdo tests.

@bradfitz
Copy link
Contributor Author

Filed #19152

@gopherbot
Copy link

CL https://golang.org/cl/37148 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Come to think of it, that CL is going to break the repo for Go 1.8. That doesn't sound good.

@alandonovan Should I set that test to only run for 1.9? It's just examples anyhow.

@golang golang locked and limited conversation to collaborators Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @ianlancetaylor @gopherbot